Change in coreboot[master]: mb/google/brya/var/kano: Update TDP PL1, PL2, and PL4 for U28 SKUs - coreboot-gerrit

2 Mar 2022


      Attention is currently required from: David Wu, Ren Kuo, Nick Vaccaro.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62466 )
Change subject: mb/google/brya/var/kano: Update TDP PL1, PL2, and PL4 for U28 SKUs
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/kano/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62466/comment/f67f8235_f3942f3a 
PS3, Line 66: 	register "power_limits_config[ADL_P_282_482_28W_CORE]" = "{
Do we still need this? you already update the cpu_power_limits limits. Update dptf entry should be enough in device tree.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62466
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib82e2dbacd6cbc39390eb28f27ca9db48d6c215c
Gerrit-Change-Number: 62466
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Peter Ou peter.ou@quanta.corp-partner.google.com
Gerrit-Attention: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Ren Kuo ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Wed, 02 Mar 2022 00:51:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment