[XS] Change in coreboot[main]: mb/google/brya: Adjust EC memory map range to support indexed IO - coreboot-gerrit

19 Dec 2024


      Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85547?usp=email )
Change subject: mb/google/brya: Adjust EC memory map range to support indexed IO
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85547/comment/4810c708_333aa7b6?usp... :
PS6, Line 15: (0x00010001 | CONFIG(EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO_PO
I guess this will cause issue,  `EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO_PORT` is a hex value
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85547?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide5026b35da7c00deab4464eedfca9d52d294fd6
Gerrit-Change-Number: 85547
Gerrit-PatchSet: 6
Gerrit-Owner: Jayvik Desai jayvik@google.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai jayvik@google.com
Gerrit-Attention: Eric Lai ericllai@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 19 Dec 2024 14:27:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No