build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68160 )
Change subject: util/cbfstool: Add a new mechanism to provide a memory mapped ......................................................................
Patch Set 1:
(5 comments)
File util/cbfstool/cbfstool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159800): https://review.coreboot.org/c/coreboot/+/68160/comment/db352115_b457b039 PS1, Line 398: * Default decode window lives just below 4G boundary in host space and maps up to a line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159800): https://review.coreboot.org/c/coreboot/+/68160/comment/c512ff9c_d5a513c6 PS1, Line 399: * maximum of 16MiB. If the window is smaller than 16MiB, the SPI flash window is mapped line length of 104 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159800): https://review.coreboot.org/c/coreboot/+/68160/comment/2637b603_07b21656 PS1, Line 402: add_mmap_window(std_window_flash_offset, DEFAULT_DECODE_WINDOW_TOP - std_window_size, std_window_size); line length of 119 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159800): https://review.coreboot.org/c/coreboot/+/68160/comment/e68a291b_93e71643 PS1, Line 411: ERROR("Flash space windows (base=0x%zx, limit=0x%zx) and (base=0x%zx, limit=0x%zx) overlap!\n", line length of 135 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159800): https://review.coreboot.org/c/coreboot/+/68160/comment/498ea8f1_974ab9bc PS1, Line 421: ERROR("Host space windows (base=0x%zx, limit=0x%zx) and (base=0x%zx, limit=0x%zx) overlap!\n", line length of 134 exceeds 96 columns