Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75131 )
Change subject: mb/amd/birman: Don't select the console UART, default to y ......................................................................
mb/amd/birman: Don't select the console UART, default to y
Things with prompts should not use selects, but should instead default to y. If there's a reason they need to be selected, they should be able to be hidden when they're selected.
This isn't one of those cases where a select is needed, so set the default to y instead.
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: If6de339c3a1ceb3cd71008402bba49b5efc4af3f --- M src/mainboard/amd/birman/Kconfig 1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/75131/1
diff --git a/src/mainboard/amd/birman/Kconfig b/src/mainboard/amd/birman/Kconfig index 5d297da..d7fd1a5 100644 --- a/src/mainboard/amd/birman/Kconfig +++ b/src/mainboard/amd/birman/Kconfig @@ -7,7 +7,6 @@ select BOARD_ROMSIZE_KB_16384 # Birman actually has a 32MiB ROM select EC_ACPI select SOC_AMD_COMMON_BLOCK_USE_ESPI if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD - select AMD_SOC_CONSOLE_UART if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD select DRIVERS_PCIE_RTD3_DEVICE select MAINBOARD_HAS_CHROMEOS select PCIEXP_ASPM @@ -48,6 +47,9 @@ The first 4 bytes form a pointer (with CRC) to where the EC firmware is located
+config AMD_SOC_CONSOLE_UART + default y if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD + config BIRMAN_MCHP_FW_FILE string "Microchip EC firmware file" depends on BIRMAN_HAVE_MCHP_FW