Attention is currently required from: Julius Werner, Jérémy Compostella, Philipp Hug, ron minnich.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81659?usp=email )
Change subject: Kconfig: Reverse ARCH_SUPPORTS_CLANG ......................................................................
Kconfig: Reverse ARCH_SUPPORTS_CLANG
Since most targets support clang it's easier to reverse the semantics of the Kconfig options.
Change-Id: Ib28e7a4cb286b9f8b05be94dae3947179f43c746 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/Kconfig M src/arch/arm/Kconfig M src/arch/arm64/Kconfig M src/arch/ppc64/Kconfig M src/arch/riscv/Kconfig M src/arch/x86/Kconfig 6 files changed, 5 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/81659/1
diff --git a/src/Kconfig b/src/Kconfig index 645d16c..9045015 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -74,7 +74,7 @@
config COMPILER_LLVM_CLANG bool "LLVM/clang" - depends on ALLOW_EXPERIMENTAL_CLANG || ARCH_SUPPORTS_CLANG + depends on ALLOW_EXPERIMENTAL_CLANG || !CLANG_UNSUPPORTED help Use LLVM/clang to build coreboot. To use this, you must build the coreboot version of the clang compiler. Run the command @@ -85,7 +85,7 @@
endchoice
-config ARCH_SUPPORTS_CLANG +config CLANG_UNSUPPORTED bool help Opt-in flag for architectures that generally work well with CLANG. @@ -93,7 +93,7 @@
config ALLOW_EXPERIMENTAL_CLANG bool "Allow experimental LLVM/Clang" - depends on !ARCH_SUPPORTS_CLANG + depends on CLANG_UNSUPPORTED help On some architectures CLANG does not work that well. Use this only to try to get CLANG working. diff --git a/src/arch/arm/Kconfig b/src/arch/arm/Kconfig index 64fe915..0829dcb 100644 --- a/src/arch/arm/Kconfig +++ b/src/arch/arm/Kconfig @@ -2,6 +2,7 @@
config ARCH_ARM bool + select CLANG_UNSUPPORTED
config ARCH_BOOTBLOCK_ARM bool diff --git a/src/arch/arm64/Kconfig b/src/arch/arm64/Kconfig index 9b89c37..1a90308 100644 --- a/src/arch/arm64/Kconfig +++ b/src/arch/arm64/Kconfig @@ -2,6 +2,7 @@
config ARCH_ARM64 bool + select CLANG_UNSUPPORTED
config ARCH_BOOTBLOCK_ARM64 bool diff --git a/src/arch/ppc64/Kconfig b/src/arch/ppc64/Kconfig index 93e4929..25a0f50 100644 --- a/src/arch/ppc64/Kconfig +++ b/src/arch/ppc64/Kconfig @@ -2,7 +2,6 @@
config ARCH_PPC64 bool - select ARCH_SUPPORTS_CLANG
config ARCH_BOOTBLOCK_PPC64 bool diff --git a/src/arch/riscv/Kconfig b/src/arch/riscv/Kconfig index b570b01..66c64c2 100644 --- a/src/arch/riscv/Kconfig +++ b/src/arch/riscv/Kconfig @@ -10,7 +10,6 @@
config ARCH_RISCV bool - select ARCH_SUPPORTS_CLANG
if ARCH_RISCV
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index d2ae320..03c4827 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -5,7 +5,6 @@ select PCI select RELOCATABLE_MODULES select HAVE_ASAN_IN_RAMSTAGE - select ARCH_SUPPORTS_CLANG
if ARCH_X86
-
Arthur Heymans (Code Review)