Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74888 )
Change subject: mb/google/rex: add fwconfig for touchscreen using SPI ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74888/comment/aa5f3751_4fd5f283 PS2, Line 7: add fwconfig for touchscreen using SPI Add FW_CONFIG for TOUCH over SPI
https://review.coreboot.org/c/coreboot/+/74888/comment/db13eb3e_77bf1e8a PS2, Line 9: =Waiting for hardware to be available you don't need any special HW to test this. This test can be done even on Proto 1 main just by setting the different CBI value
for example: SKU3 (w/ FM350)
to test the HID over SPI
cbi set 6 0x83522 4
to test the HID over I2C
cbi set 6 0x3522 4
for example: SKU3 (w/ FM101)
to test the HID over SPI
cbi set 6 0x83512 4
to test the HID over I2C
cbi set 6 0x3512 4
-
Subrata Banik (Code Review)