Attention is currently required from: Alexander Couzens, Patrick Rudolph.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79942?usp=email )
Change subject: mb/lenovo/t430: Remove superfluous comments related to PCI devices
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/lenovo/t430s/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79942/comment/5b1323c2_c6270caa :
PS1, Line 72: device ref pcie_rp6 off end # Intel Gigabit Ethernet PHY (not PCIe)
why has it such a comment? it's off?
Probably copy pasta. Removed.
File src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79942/comment/b023c0dd_0bd5a49c :
PS1, Line 18: device ref peg10 off end
Readd comment "discrete graphics"
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79942?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I84f432e89c41a02115715f7f1b56123dd0d81171
Gerrit-Change-Number: 79942
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Thu, 18 Jan 2024 00:02:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment