Casper Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31034
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
mb/google/arcada: Add settings for noise mitgation
Enable acoustic noise mitgation for arcada platform, the slow slew rates are fast time dived by 2.
BUG=none BRANCH=none TEST=none
Change-Id: Ia838818a76a7f638b24146f3eb48493a4091c9cb --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/31034/1
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index ff26cbf..af8fe18 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -36,6 +36,11 @@ register "tdp_pl1_override" = "25" register "tdp_pl2_override" = "51" register "Device4Enable" = "1" + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRateForIa" = "0" + register "SlowSlewRateForGt" = "0" + register "SlowSlewRateForSa" = "0" + register "SlowSlewRateForFivr" = "0"
# Intel Common SoC Config register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" # Left Type-C Port
Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31034 )
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
Patch Set 1: Code-Review+1
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31034 )
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31034/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31034/1//COMMIT_MSG@17 PS1, Line 17: Can you add a Signed-off-by line? That is what triggered the verified -1.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31034 )
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
Patch Set 1:
You can run make gitconfig first before submit, that will introduce a script to check that.
Hello Duncan Laurie, Lijian Zhao, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31034
to look at the new patch set (#2).
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
mb/google/arcada: Add settings for noise mitgation
Enable acoustic noise mitgation for arcada platform, the slow slew rates are fast time dived by 2.
BUG=none BRANCH=none TEST=none
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: Ia838818a76a7f638b24146f3eb48493a4091c9cb Reviewed-on: https://review.coreboot.org/c/coreboot/+/31034 --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/31034/2
Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31034 )
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
Patch Set 2:
(1 comment)
Patch Set 1:
You can run make gitconfig first before submit, that will introduce a script to check that.
Got it! Thank you very much.
https://review.coreboot.org/#/c/31034/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31034/1//COMMIT_MSG@17 PS1, Line 17:
Can you add a Signed-off-by line? That is what triggered the verified -1.
added.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31034 )
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31034 )
Change subject: mb/google/arcada: Add settings for noise mitgation ......................................................................
mb/google/arcada: Add settings for noise mitgation
Enable acoustic noise mitgation for arcada platform, the slow slew rates are fast time dived by 2.
BUG=none BRANCH=none TEST=none
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: Ia838818a76a7f638b24146f3eb48493a4091c9cb Reviewed-on: https://review.coreboot.org/c/coreboot/+/31034 Reviewed-on: https://review.coreboot.org/c/31034 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lijian Zhao lijian.zhao@intel.com --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved Casper Chang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index ff26cbf..af8fe18 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -36,6 +36,11 @@ register "tdp_pl1_override" = "25" register "tdp_pl2_override" = "51" register "Device4Enable" = "1" + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRateForIa" = "0" + register "SlowSlewRateForGt" = "0" + register "SlowSlewRateForSa" = "0" + register "SlowSlewRateForFivr" = "0"
# Intel Common SoC Config register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)" # Left Type-C Port
-
Casper Chang (Code Review) -
Duncan Laurie (Code Review)
-
Lijian Zhao (Code Review)
-
Patrick Georgi (Code Review)