Attention is currently required from: Arthur Heymans, Christian Walter, Maximilian Brune, ron minnich.
Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68843?usp=email )
Change subject: mb/emulation/riscv: Limit DRAM size
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
File src/mainboard/emulation/qemu-riscv/Kconfig:
https://review.coreboot.org/c/coreboot/+/68843/comment/b0aa72fc_e0edd736 :
PS1, Line 48: # To avoid confusing the dram probing algoritm, avoid large dram sizes (16G - 1m)
'algoritm' may be misspelled - perhaps 'algorithm'? […]
Done
https://review.coreboot.org/c/coreboot/+/68843/comment/a773c9e1_d02303c7 :
PS1, Line 47: Qemu maps MMIO at ALIGN_UP(top_of_mem, 16 * GiB)
: # To avoid confusing the dram probing algoritm, avoid large dram sizes (16G - 1m)
you could just as well put it in the help text I guess.
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68843?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib8555de361d1129d3d1995f056518c576f055515
Gerrit-Change-Number: 68843
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Sat, 03 Feb 2024 16:54:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment