[L] Change in coreboot[master]: lib/coreboot_table: Simplify API to set up lb_serial - coreboot-gerrit

3 Nov 2022


      Attention is currently required from: Jakub Czapiga, Julius Werner, ron minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68768 )
Change subject: lib/coreboot_table: Simplify API to set up lb_serial
......................................................................
Patch Set 10:
(1 comment)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/68768/comment/d0616a20_4a5ea2ee 
PS10, Line 104: get_lb_serial
...
One more nit: I just noticed that there's already 'lb_pcie' and 'lb_fill_pcie' doing exactly the sam […]
Done. I also renamed the pcie call in a follow-up as 'fill_lb_xxx' seems to be more common.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68768
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c08a88fb5fc035eb28d0becf19471c709c8043d
Gerrit-Change-Number: 68768
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 09:58:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment