Justin Frodsham has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44450 )
Change subject: mb/google/zork: Add missing clock power management dxio descriptor initializers to trembyle and dalboz. ......................................................................
mb/google/zork: Add missing clock power management dxio descriptor initializers to trembyle and dalboz.
BUG=b:162423378 TEST=MAke sure the clk pm config callback executed properly
Change-Id: Ifabbb5820b9b995e7d84489a834a6f7b82db4636 --- M src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c M src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/44450/1
diff --git a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c index c6e63ad..50fce1a 100644 --- a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c +++ b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c @@ -57,6 +57,7 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ1, + .clk_pm_support = true, } };
diff --git a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c index 26a5d33..8a15854 100644 --- a/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c +++ b/src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c @@ -32,6 +32,7 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ4, + .clk_pm_support = true, }, { // WLAN @@ -61,6 +62,7 @@ .link_aspm_L1_2 = true, .turn_off_unused_lanes = true, .clk_req = CLK_REQ1, + .clk_pm_support = true, } };
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44450 )
Change subject: mb/google/zork: Add missing clock power management dxio descriptor initializers to trembyle and dalboz. ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44450/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44450/1//COMMIT_MSG@10 PS1, Line 10: MAke sure the clk pm config callback executed properly Did you figure out what `clk_pm_support` really does? There is still pending question on the linked bug to understand the usage of `clk_pm_support`: https://b.corp.google.com/issues/162423378#comment10
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44450
to look at the new patch set (#2).
Change subject: mb/google/zork: Add missing clock power management dxio descriptor initializers to trembyle and dalboz. ......................................................................
mb/google/zork: Add missing clock power management dxio descriptor initializers to trembyle and dalboz.
BUG=b:162423378 TEST=Make sure the clock power management config callback executed properly
Change-Id: Ifabbb5820b9b995e7d84489a834a6f7b82db4636 --- M src/mainboard/google/zork/variants/baseboard/fsps_baseboard_dalboz.c M src/mainboard/google/zork/variants/baseboard/fsps_baseboard_trembyle.c 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/44450/2
Justin Frodsham has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44450 )
Change subject: mb/google/zork: Add missing clock power management dxio descriptor initializers to trembyle and dalboz. ......................................................................
Patch Set 2:
(1 comment)
Added a comment to the issue. The flag was not being honored before, but should be now.
https://review.coreboot.org/c/coreboot/+/44450/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44450/1//COMMIT_MSG@10 PS1, Line 10: MAke sure the clk pm config callback executed properly
Did you figure out what `clk_pm_support` really does? There is still pending question on the linked […]
Ack
Justin Frodsham has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44450 )
Change subject: mb/google/zork: Add missing clock power management dxio descriptor initializers to trembyle and dalboz. ......................................................................
Abandoned
These fields are now redundant, will be removing from all initializer definitions.