Change in coreboot[master]: mb/google/dedede: Add BT Disable GPIO configuration

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Karthik Ramasubramanian (Code Review)

11 Mar 2020 11 Mar '20

5:03 a.m.

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39446 )

Change subject: mb/google/dedede: Add BT Disable GPIO configuration ......................................................................

mb/google/dedede: Add BT Disable GPIO configuration

TEST=Build and boot the mainboard.

Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I0406a68ffcab2675a1aedb212cb7c8508a5b61fc --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c 2 files changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/39446/1

diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index 994e96e..5a635b3 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -190,6 +190,7 @@ chip drivers/usb/acpi register "desc" = ""Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)" device usb 2.4 on end end chip drivers/usb/acpi diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index af95f6a..49af7fe 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -328,7 +328,7 @@ /* H18 : WLAN_DISABLE_L */ PAD_NC(GPP_H18, NONE), /* H19 : BT_DISABLE_L */ - PAD_NC(GPP_H19, NONE), + PAD_CFG_GPO(GPP_H19, 1, DEEP),

/* R0 : I2S_HP_BCLK */ PAD_NC(GPP_R0, NONE),

Attachments:

attachment.htm (text/html — 3.4 KB)

Show replies by date

Tim Wawrzynczak (Code Review)

11 Mar 11 Mar

4:43 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39446 )

Change subject: mb/google/dedede: Add BT Disable GPIO configuration ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39446/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39446/1/src/mainboard/google/dedede... PS1, Line 331: 1 In previous programs, we've kept this reset active at GPIO config time. WDYT?

-- To view, visit https://review.coreboot.org/c/coreboot/+/39446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0406a68ffcab2675a1aedb212cb7c8508a5b61fc Gerrit-Change-Number: 39446 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 11 Mar 2020 15:43:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

12 Mar 12 Mar

6:54 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39446

to look at the new patch set (#2).

Change subject: mb/google/dedede: Add BT Disable GPIO configuration ......................................................................

mb/google/dedede: Add BT Disable GPIO configuration

Disable the BT module in bootblock and enable it in ramstage. This allows for loading the BT firmware during reboot.

TEST=Build and boot the mainboard.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/39446/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0406a68ffcab2675a1aedb212cb7c8508a5b61fc Gerrit-Change-Number: 39446 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

6:56 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39446 )

Change subject: mb/google/dedede: Add BT Disable GPIO configuration ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39446/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39446/1/src/mainboard/google/dedede... PS1, Line 331: 1

...

In previous programs, we've kept this reset active at GPIO config time. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0406a68ffcab2675a1aedb212cb7c8508a5b61fc Gerrit-Change-Number: 39446 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Mar 2020 05:56:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

3:24 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39446 )

Change subject: mb/google/dedede: Add BT Disable GPIO configuration ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39446/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39446/2/src/mainboard/google/dedede... PS2, Line 414: PAD_CFG_GPO(GPP_H19, 0, DEEP), I don't think it needs to be configured in bootblock. I just meant to enable the reset when configuring GPIOs, and then let the kernel drive the reset as it wants to.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0406a68ffcab2675a1aedb212cb7c8508a5b61fc Gerrit-Change-Number: 39446 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Mar 2020 14:24:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

10:49 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39446 )

Change subject: mb/google/dedede: Add BT Disable GPIO configuration ......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/39446/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39446/2/src/mainboard/google/dedede... PS2, Line 414: PAD_CFG_GPO(GPP_H19, 0, DEEP),

...

I don't think it needs to be configured in bootblock. […]

Whoops, read this wrong. LGTM.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0406a68ffcab2675a1aedb212cb7c8508a5b61fc Gerrit-Change-Number: 39446 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Mar 2020 21:49:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Martin Roth (Code Review)

15 Mar 15 Mar

12:29 a.m.

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39446 )

Change subject: mb/google/dedede: Add BT Disable GPIO configuration ......................................................................

mb/google/dedede: Add BT Disable GPIO configuration

Disable the BT module in bootblock and enable it in ramstage. This allows for loading the BT firmware during reboot.

TEST=Build and boot the mainboard.

Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I0406a68ffcab2675a1aedb212cb7c8508a5b61fc Reviewed-on: https://review.coreboot.org/c/coreboot/+/39446 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/baseboard/gpio.c 2 files changed, 5 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index 994e96e..5a635b3 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -190,6 +190,7 @@ chip drivers/usb/acpi register "desc" = ""Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)" device usb 2.4 on end end chip drivers/usb/acpi diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index fe903bd..20c7be9 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -328,7 +328,7 @@ /* H18 : WLAN_DISABLE_L */ PAD_NC(GPP_H18, NONE), /* H19 : BT_DISABLE_L */ - PAD_NC(GPP_H19, NONE), + PAD_CFG_GPO(GPP_H19, 1, DEEP),

/* R0 : I2S_HP_BCLK */ PAD_NC(GPP_R0, NONE), @@ -409,6 +409,9 @@ PAD_CFG_GPI(GPP_C4, NONE, DEEP), /* C5 : RAM_STRAP_3 */ PAD_CFG_GPI(GPP_C5, NONE, DEEP), + + /* H19 : BT_DISABLE_L */ + PAD_CFG_GPO(GPP_H19, 0, DEEP), };

const struct pad_config *__weak variant_gpio_table(size_t *num)

-- To view, visit https://review.coreboot.org/c/coreboot/+/39446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0406a68ffcab2675a1aedb212cb7c8508a5b61fc Gerrit-Change-Number: 39446 Gerrit-PatchSet: 5 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1655

days inactive

1658

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Karthik Ramasubramanian (Code Review)
Martin Roth (Code Review)
Tim Wawrzynczak (Code Review)