Attention is currently required from: Martin Roth - Personal, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 )
Change subject: [WIP]drivers/efi: Add UEFI variable store option support ......................................................................
Patch Set 3:
(15 comments)
File src/commonlib/bsd/include/commonlib/bsd/cb_err.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/b9a90b03_0bc44e09 PS3, Line 29: CB_EFI_VS_NOT_FORMATED_INVALID = -107, /**< UEFI variable store not formated */ 'FORMATED' may be misspelled - perhaps 'FORMATTED'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/f0964dea_6b1e62dd PS3, Line 29: CB_EFI_VS_NOT_FORMATED_INVALID = -107, /**< UEFI variable store not formated */ 'formated' may be misspelled - perhaps 'formatted'?
File src/drivers/efi/efi.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/099528ed_c7550de3 PS3, Line 9: enum cb_err efi_fv_get_option(struct region_device *rdev, const char *name, void *dest, uint32_t *size); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/244ef90c_d300db92 PS3, Line 10: enum cb_err efi_fv_set_option(struct region_device *rdev, const char *name, void *data, size_t size); line over 96 characters
File src/drivers/efi/efi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/e5a5dad9_b037068f PS3, Line 82: if ( (fw_vol_hdr->Revision != EFI_FVH_REVISION) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/6e672ec2_92884c90 PS3, Line 82: if ( (fw_vol_hdr->Revision != EFI_FVH_REVISION) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/469eef9a_d6fbe109 PS3, Line 147: return CB_EFI_VS_NOT_FORMATED_INVALID; 'FORMATED' may be misspelled - perhaps 'FORMATTED'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/82a12b5a_5fdc0956 PS3, Line 235: !name ) { space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/cca5d7a8_a07d0dbb PS3, Line 250: if (rdev_readat(rdev, data, header_size + name_size, data_size) != data_size) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/dc915bfa_b00dcbe5 PS3, Line 250: if (rdev_readat(rdev, data, header_size + name_size, data_size) != data_size) Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/e36364ea_6002f796 PS3, Line 275: enum cb_err efi_fv_get_option(struct region_device *rdev, const char *name, void *dest, uint32_t *size) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/abfe4ce3_967de833 PS3, Line 307: enum cb_err efi_fv_set_option(struct region_device *rdev, const char *name, void *data, size_t size) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/ffe33224_f9f98048 PS3, Line 345: auth_hdr.Attributes = EFI_VARIABLE_NON_VOLATILE|EFI_VARIABLE_BOOTSERVICE_ACCESS|EFI_VARIABLE_RUNTIME_ACCESS; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/781c6c49_22062b0c PS3, Line 357: if (rdev_writeat(rdev, &auth_hdr.State, offsetof(AUTHENTICATED_VARIABLE_HEADER, State), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597): https://review.coreboot.org/c/coreboot/+/52564/comment/378cecad_1c8278df PS3, Line 369: hdr.Attributes = EFI_VARIABLE_NON_VOLATILE|EFI_VARIABLE_BOOTSERVICE_ACCESS|EFI_VARIABLE_RUNTIME_ACCESS; line over 96 characters
-
build bot (Jenkins) (Code Review)