Hello Kane Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23020
to look at the new patch set (#2).
Change subject: mb/google/fizz: Override IccMax settings ......................................................................
mb/google/fizz: Override IccMax settings
According to Intel document #559100 KBL EDS v2.8, section 7.2 DC specifications, the IccMax setting for KBL-U, KBL-U42 and Celeron are different. This patch sets Celeron as default SKU in device tree and overrides the IccMax settings for KBL-U and KBL-U42 at pre-FSPS.
+----------------+-------------+---------------+-------+-------+ | Domain/Setting | SA | IA | GTUS | GTS | +----------------+-------------+---------------+-------+-------+ | IccMax | 6A(U42) | 64A(U42) | 31A | 31A | | | 4.5A(Others)| 29A(Celeron) | 31A | 31A |(Default) | | | 32A(i3/i5) | 31A | 31A | +----------------+-------------+-------+-------+-------+-------+
BUG=b:71369428 BRANCH=None TEST=emerge-fizz coreboot chromeos-bootimage & Ensure the KBL-U42, KBL-U and Celeron SKUs are identified correctly and IccMax settings are passed to FSPS correctly.
Change-Id: I32ffe0cb73981850005b20fefb6664cfab74fbca Signed-off-by: Gaggery Tsai gaggery.tsai@intel.com --- A src/mainboard/google/fizz/common.h M src/mainboard/google/fizz/devicetree.cb M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/fizz/ramstage.c 4 files changed, 82 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/23020/2