Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39502 )
Change subject: mb/google/deltaur: add deltaur mainboard initial support ......................................................................
Patch Set 7:
(12 comments)
Sorry to be a pain with the SPDX headers, but we'll get used to it 😊
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 29: /* Low power idle table */ #include <soc/intel/cannonlake/acpi/lpit.asl>
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 40: #include <vendorcode/google/chromeos/acpi/vpd.asl>
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 49: Should we hold off on DPTF for now?
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: ## SPDX format please
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/gpio.c:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /* /* * This file is part of the coreboot project. * * Copyright 2020 The coreboot project Authors. * * SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /* /* * This file is part of the coreboot project. * * Copyright 2020 The coreboot project Authors. * * SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /* /* * This file is part of the coreboot project. * * Copyright 2020 The coreboot project Authors. * * SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: ## SPDX
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/gpio.c:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /* /* * This file is part of the coreboot project. * * Copyright 2020 The coreboot project Authors. * * SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /* /* * This file is part of the coreboot project. * * Copyright 2020 The coreboot project Authors. * * SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 1: /* /* * This file is part of the coreboot project. * * Copyright 2020 The coreboot project Authors. * * SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/39502/7/src/mainboard/google/deltau... PS7, Line 22: GPP_E2 GPP_C22, H1_FLASH_WP
-
Tim Wawrzynczak (Code Review)