Julius Werner has posted comments on this change. ( https://review.coreboot.org/27474 )
Change subject: libpayload/xhci: Document struct offsets on xhci_t
......................................................................
Patch Set 1: Code-Review+2
Not sure this is really necessary since these offsets are in the XHCI spec and people usually know the registers by name anyway... but I guess it doesn't hurt either.
--
To view, visit
https://review.coreboot.org/27474
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92dcbd463ceb4dd8edbbd97b51a4e9aa32a983a6
Gerrit-Change-Number: 27474
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 13 Jul 2018 22:16:06 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes