Change in coreboot[master]: soc/intel: make uart_max_index's value reflect what its name pretends - coreboot-gerrit

11 Jan 2021


      Attention is currently required from:  Felix Singer, Furquan Shaikh, Tim Wawrzynczak, Michael Niewöhner, Andrey Petrov, Patrick Rudolph, Karthik Ramasubramanian.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49305 )
Change subject: soc/intel: make uart_max_index's value reflect what its name pretends
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1: 
Wouldn't it be even better to rename it to `uart_..._size` instead?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49305
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7409c9dc040c3c6ad718abc96f268c187d50d79c
Gerrit-Change-Number: 49305
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention:  Felix Singer felixsinger@posteo.net
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 11 Jan 2021 23:40:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment