Patch set updated for coreboot: AMD fam10 binaryPI: Remove invalid PCI ops on CPU domain

[Kyösti Mälkki]

Kyösti Mälkki ([e-mail]) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17697

-gerrit

commit 7858250565f52b362643d15995d2cb4c5387550d
Author: Kyösti Mälkki 
Date:   Fri Dec 2 16:02:30 2016 +0200

AMD fam10 binaryPI: Remove invalid PCI ops on CPU domain

Device is of type CPU_CLUSTER, while pci_dev_set_resources()
    expects PCI_DOMAIN.

Change-Id: Ib1add47d71071abb6e9c28e3a85dd0b671741b71
    Signed-off-by: Kyösti Mälkki 
---
 src/northbridge/amd/agesa/family10/northbridge.c | 13 ++-----------
 src/northbridge/amd/agesa/family12/northbridge.c | 20 ++------------------
 src/northbridge/amd/amdfam10/northbridge.c       |  7 +------
 src/northbridge/amd/pi/00660F01/northbridge.c    | 13 ++-----------
 src/northbridge/amd/pi/00670F00/northbridge.c    | 13 ++-----------
 src/northbridge/amd/pi/00730F01/northbridge.c    | 13 ++-----------
 6 files changed, 11 insertions(+), 68 deletions(-)

diff --git a/src/northbridge/amd/agesa/family10/northbridge.c b/src/northbridge/amd/agesa/family10/northbridge.c
index a50e09b..6f7a053 100644
--- a/src/northbridge/amd/agesa/family10/northbridge.c
+++ b/src/northbridge/amd/agesa/family10/northbridge.c
@@ -1101,18 +1101,9 @@ static void cpu_bus_init(device_t dev)
    initialize_cpus(dev->link_list);
 }

-static void cpu_bus_read_resources(device_t dev)
-{
-}
-
-static void cpu_bus_set_resources(device_t dev)
-{
-	pci_dev_set_resources(dev);
-}
-
 static struct device_operations cpu_bus_ops = {
-	.read_resources	  = cpu_bus_read_resources,
-	.set_resources	  = cpu_bus_set_resources,
+	.read_resources	  = DEVICE_NOOP,
+	.set_resources	  = DEVICE_NOOP,
    .enable_resources = DEVICE_NOOP,
    .init		  = cpu_bus_init,
    .scan_bus	  = cpu_bus_scan,
diff --git a/src/northbridge/amd/agesa/family12/northbridge.c b/src/northbridge/amd/agesa/family12/northbridge.c
index e3541e1..c8198c9 100644
--- a/src/northbridge/amd/agesa/family12/northbridge.c
+++ b/src/northbridge/amd/agesa/family12/northbridge.c
@@ -652,22 +652,6 @@ static void domain_enable_resources(device_t dev)

/* Bus related code */

-
-static void cpu_bus_read_resources(device_t dev)
-{
-	printk(BIOS_DEBUG, "\nFam12h - northbridge.c - %s - Start.\n",__func__);
-
-	printk(BIOS_DEBUG, "Fam12h - northbridge.c - %s - End.\n",__func__);
-}
-
-static void cpu_bus_set_resources(device_t dev)
-{
-	printk(BIOS_DEBUG, "\nFam12h - northbridge.c - %s - Start.\n",__func__);
-	pci_dev_set_resources(dev);
-
-	printk(BIOS_DEBUG, "Fam12h - northbridge.c - %s - End.\n",__func__);
-}
-
 static void cpu_bus_init(device_t dev)
 {
    printk(BIOS_DEBUG, "\nFam12h - northbridge.c - %s - Start.\n",__func__);
@@ -813,8 +797,8 @@ static struct device_operations pci_domain_ops = {

static struct device_operations cpu_bus_ops = {
-	.read_resources   = cpu_bus_read_resources,
-	.set_resources    = cpu_bus_set_resources,
+	.read_resources   = DEVICE_NOOP,
+	.set_resources    = DEVICE_NOOP,
    .enable_resources = DEVICE_NOOP,
    .init             = cpu_bus_init,
    .scan_bus         = 0,
diff --git a/src/northbridge/amd/amdfam10/northbridge.c b/src/northbridge/amd/amdfam10/northbridge.c
index 8d1d498..6d757d9 100644
--- a/src/northbridge/amd/amdfam10/northbridge.c
+++ b/src/northbridge/amd/amdfam10/northbridge.c
@@ -1955,14 +1955,9 @@ static void cpu_bus_init(device_t dev)
 #endif
 }

-static void cpu_bus_set_resources(struct device *dev)
-{
-	pci_dev_set_resources(dev);
-}
-
 static struct device_operations cpu_bus_ops = {
    .read_resources	  = DEVICE_NOOP,
-	.set_resources	  = cpu_bus_set_resources,
+	.set_resources	  = DEVICE_NOOP,
    .enable_resources = DEVICE_NOOP,
    .init		  = cpu_bus_init,
    .scan_bus	  = cpu_bus_scan,
diff --git a/src/northbridge/amd/pi/00660F01/northbridge.c b/src/northbridge/amd/pi/00660F01/northbridge.c
index be748e8..9fc2dca 100644
--- a/src/northbridge/amd/pi/00660F01/northbridge.c
+++ b/src/northbridge/amd/pi/00660F01/northbridge.c
@@ -1088,18 +1088,9 @@ static void cpu_bus_init(device_t dev)
    initialize_cpus(dev->link_list);
 }

-static void cpu_bus_read_resources(device_t dev)
-{
-}
-
-static void cpu_bus_set_resources(device_t dev)
-{
-	pci_dev_set_resources(dev);
-}
-
 static struct device_operations cpu_bus_ops = {
-	.read_resources	  = cpu_bus_read_resources,
-	.set_resources	  = cpu_bus_set_resources,
+	.read_resources	  = DEVICE_NOOP,
+	.set_resources	  = DEVICE_NOOP,
    .enable_resources = DEVICE_NOOP,
    .init		  = cpu_bus_init,
    .scan_bus	  = cpu_bus_scan,
diff --git a/src/northbridge/amd/pi/00670F00/northbridge.c b/src/northbridge/amd/pi/00670F00/northbridge.c
index ae847d2..c21d030 100644
--- a/src/northbridge/amd/pi/00670F00/northbridge.c
+++ b/src/northbridge/amd/pi/00670F00/northbridge.c
@@ -1089,18 +1089,9 @@ static void cpu_bus_init(device_t dev)
    initialize_cpus(dev->link_list);
 }

-static void cpu_bus_read_resources(device_t dev)
-{
-}
-
-static void cpu_bus_set_resources(device_t dev)
-{
-	pci_dev_set_resources(dev);
-}
-
 static struct device_operations cpu_bus_ops = {
-	.read_resources	  = cpu_bus_read_resources,
-	.set_resources	  = cpu_bus_set_resources,
+	.read_resources	  = DEVICE_NOOP,
+	.set_resources	  = DEVICE_NOOP,
    .enable_resources = DEVICE_NOOP,
    .init		  = cpu_bus_init,
    .scan_bus	  = cpu_bus_scan,
diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c
index 58fb47a..ed8e17a 100644
--- a/src/northbridge/amd/pi/00730F01/northbridge.c
+++ b/src/northbridge/amd/pi/00730F01/northbridge.c
@@ -1108,18 +1108,9 @@ static void cpu_bus_init(device_t dev)
    initialize_cpus(dev->link_list);
 }

-static void cpu_bus_read_resources(device_t dev)
-{
-}
-
-static void cpu_bus_set_resources(device_t dev)
-{
-	pci_dev_set_resources(dev);
-}
-
 static struct device_operations cpu_bus_ops = {
-	.read_resources	  = cpu_bus_read_resources,
-	.set_resources	  = cpu_bus_set_resources,
+	.read_resources	  = DEVICE_NOOP,
+	.set_resources	  = DEVICE_NOOP,
    .enable_resources = DEVICE_NOOP,
    .init		  = cpu_bus_init,
    .scan_bus	  = cpu_bus_scan,