David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46874 )
Change subject: mb/google/volteer/var/terrador: Disable DPTF active policy ......................................................................
mb/google/volteer/var/terrador: Disable DPTF active policy
Disable DPTF active policy for terrador and todor.
BUG=b:171019363,b:170699797 BRANCH=volteer TEST=build and verify by thermal team
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I53a33b8706d7a7d4013a2a5627a620223fcffc3e --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/46874/1
diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb index ae26e79..e40ed03 100644 --- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb +++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb @@ -22,6 +22,9 @@ device domain 0 on device ref dptf on chip drivers/intel/dptf + ## Disable Active Policy + register "policies.active" = "{[0] = {.target=DPTF_NONE}}" + ## Passive Policy register "policies.passive" = "{ [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000), diff --git a/src/mainboard/google/volteer/variants/todor/overridetree.cb b/src/mainboard/google/volteer/variants/todor/overridetree.cb index ae26e79..e40ed03 100644 --- a/src/mainboard/google/volteer/variants/todor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/todor/overridetree.cb @@ -22,6 +22,9 @@ device domain 0 on device ref dptf on chip drivers/intel/dptf + ## Disable Active Policy + register "policies.active" = "{[0] = {.target=DPTF_NONE}}" + ## Passive Policy register "policies.passive" = "{ [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000),
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46874 )
Change subject: mb/google/volteer/var/terrador: Disable DPTF active policy ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46874/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46874/1//COMMIT_MSG@7 PS1, Line 7: mb/google/volteer/var/terrador: Disable DPTF active policy mb/google/volteer: Disable DPTF active policy for terrador and todor
https://review.coreboot.org/c/coreboot/+/46874/1//COMMIT_MSG@9 PS1, Line 9: Disable DPTF active policy for terrador and todor. Maybe add just one line here as to why it's being disabled.
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46874
to look at the new patch set (#2).
Change subject: mb/google/volteer: Disable DPTF active policy for terrador and todor ......................................................................
mb/google/volteer: Disable DPTF active policy for terrador and todor
Terrador and Todor are fanless design, so disable DPTF active policy.
BUG=b:171019363,b:170699797 BRANCH=volteer TEST=build and verify by thermal team
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I53a33b8706d7a7d4013a2a5627a620223fcffc3e --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/46874/2
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46874 )
Change subject: mb/google/volteer: Disable DPTF active policy for terrador and todor ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46874/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46874/1//COMMIT_MSG@7 PS1, Line 7: mb/google/volteer/var/terrador: Disable DPTF active policy
mb/google/volteer: Disable DPTF active policy for terrador and todor
Done
https://review.coreboot.org/c/coreboot/+/46874/1//COMMIT_MSG@9 PS1, Line 9: Disable DPTF active policy for terrador and todor.
Maybe add just one line here as to why it's being disabled.
Done
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46874 )
Change subject: mb/google/volteer: Disable DPTF active policy for terrador and todor ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46874 )
Change subject: mb/google/volteer: Disable DPTF active policy for terrador and todor ......................................................................
mb/google/volteer: Disable DPTF active policy for terrador and todor
Terrador and Todor are fanless design, so disable DPTF active policy.
BUG=b:171019363,b:170699797 BRANCH=volteer TEST=build and verify by thermal team
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I53a33b8706d7a7d4013a2a5627a620223fcffc3e Reviewed-on: https://review.coreboot.org/c/coreboot/+/46874 Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Fagerburg: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb index d62a303..fbf724f 100644 --- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb +++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb @@ -22,6 +22,9 @@ device domain 0 on device ref dptf on chip drivers/intel/dptf + ## Disable Active Policy + register "policies.active" = "{[0] = {.target=DPTF_NONE}}" + ## Passive Policy register "policies.passive" = "{ [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000), diff --git a/src/mainboard/google/volteer/variants/todor/overridetree.cb b/src/mainboard/google/volteer/variants/todor/overridetree.cb index d62a303..fbf724f 100644 --- a/src/mainboard/google/volteer/variants/todor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/todor/overridetree.cb @@ -22,6 +22,9 @@ device domain 0 on device ref dptf on chip drivers/intel/dptf + ## Disable Active Policy + register "policies.active" = "{[0] = {.target=DPTF_NONE}}" + ## Passive Policy register "policies.passive" = "{ [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000),
-
David Wu (Code Review) -
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)