Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86011?usp=email )
Change subject: mb/google/fatcat/var/francka: Fix incorrect memory ram_id ......................................................................
mb/google/fatcat/var/francka: Fix incorrect memory ram_id
Fix ram_id index is always "0".
Memory configuration board straps: GPIO_MEM_CONFIG_0 GPP_D08 GPIO_MEM_CONFIG_1 GPP_D07
BUG=b:372395010, b:381992696 TEST=emerge-fatcat coreboot
Change-Id: I24ba06bc8d61ac5bd372ff4611d3ea876ac9bb92 Signed-off-by: Ian Feng ian_feng@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/86011 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com --- M src/mainboard/google/fatcat/variants/francka/memory.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Dtrain Hsu: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/fatcat/variants/francka/memory.c b/src/mainboard/google/fatcat/variants/francka/memory.c index 74d74cd..c5b8165 100644 --- a/src/mainboard/google/fatcat/variants/francka/memory.c +++ b/src/mainboard/google/fatcat/variants/francka/memory.c @@ -89,5 +89,5 @@ void variant_get_spd_info(struct mem_spd *spd_info) { spd_info->topo = MEM_TOPO_MEMORY_DOWN; - spd_info->cbfs_index = 0; + spd_info->cbfs_index = variant_memory_sku(); }