Change in coreboot[master]: cpu/x86/smm_module_load: Rewrite setup_stub - coreboot-gerrit

7 Apr 2022


      Attention is currently required from: Arthur Heymans.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63478 )
Change subject: cpu/x86/smm_module_load: Rewrite setup_stub
......................................................................
Patch Set 4:
(1 comment)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/63478/comment/2e06ae0e_26e90e6e 
PS4, Line 323: smm_stub_place_staggered_entry_points
...
...
the bug was filling in the stub_params->c_handler before calling this function correct? […]
sorry I missed the word "not" in there, "not filling it before calling" 😊
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42ef9d6a30f3039f25e2cde975086a1365ca4182
Gerrit-Change-Number: 63478
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 07 Apr 2022 23:16:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment