HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39927 )
Change subject: superio/{acpi,common}: Remove some unneeded white spaces ......................................................................
superio/{acpi,common}: Remove some unneeded white spaces
Change-Id: I879ac7b558781d559a65c97fc8b914ecc4ad3f0d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/acpi/pnp_generic.asl M src/superio/acpi/pnp_uart.asl M src/superio/common/generic.c 3 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/39927/1
diff --git a/src/superio/acpi/pnp_generic.asl b/src/superio/acpi/pnp_generic.asl index cb92a5d..afec200 100644 --- a/src/superio/acpi/pnp_generic.asl +++ b/src/superio/acpi/pnp_generic.asl @@ -13,7 +13,7 @@ * SUPERIO_PNP_LDN The logical device number on the Super I/O * chip for this device (required) * SUPERIO_PNP_DDN A string literal that identifies the dos device - * name (DDN) of this device (e.g. "COM1", optional) + * name (DDN) of this device (e.g. "COM1", optional) * SUPERIO_PNP_PM_REG Identifier of a 1-bit register to power down * the logical device (optional) * SUPERIO_PNP_PM_VAL The value for SUPERIO_PNP_PM_REG to power the logical diff --git a/src/superio/acpi/pnp_uart.asl b/src/superio/acpi/pnp_uart.asl index 859430e..751f955 100644 --- a/src/superio/acpi/pnp_uart.asl +++ b/src/superio/acpi/pnp_uart.asl @@ -12,7 +12,7 @@ * SUPERIO_UART_LDN The logical device number on the Super I/O * chip for this UART (required) * SUPERIO_UART_DDN A string literal that identifies the dos device - * name (DDN) of this uart (e.g. "COM1", optional) + * name (DDN) of this uart (e.g. "COM1", optional) * SUPERIO_UART_PM_REG Identifier of a 1-bit register to power down * the UART (optional) * SUPERIO_UART_PM_VAL The value for SUPERIO_UART_PM_REG to power the logical diff --git a/src/superio/common/generic.c b/src/superio/common/generic.c index de78199..809f886 100644 --- a/src/superio/common/generic.c +++ b/src/superio/common/generic.c @@ -37,8 +37,7 @@ const char *name = acpi_device_name(dev);
if (!scope || !name) { - printk(BIOS_ERR, "%s: Missing ACPI path/scope\n", - dev_path(dev)); + printk(BIOS_ERR, "%s: Missing ACPI path/scope\n", dev_path(dev)); return; }
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39927 )
Change subject: superio/{acpi,common}: Remove some unneeded white spaces ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39927/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39927/1//COMMIT_MSG@7 PS1, Line 7: white spaces white space
Hello build bot (Jenkins), Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39927
to look at the new patch set (#2).
Change subject: superio/{acpi,common}: Improve code formatting ......................................................................
superio/{acpi,common}: Improve code formatting
Change-Id: I879ac7b558781d559a65c97fc8b914ecc4ad3f0d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/acpi/pnp_generic.asl M src/superio/acpi/pnp_uart.asl M src/superio/common/generic.c 3 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/39927/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39927 )
Change subject: superio/{acpi,common}: Improve code formatting ......................................................................
Patch Set 2:
(1 comment)
Thx
https://review.coreboot.org/c/coreboot/+/39927/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39927/1//COMMIT_MSG@7 PS1, Line 7: white spaces
white space
Ack
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39927 )
Change subject: superio/{acpi,common}: Improve code formatting ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39927 )
Change subject: superio/{acpi,common}: Improve code formatting ......................................................................
superio/{acpi,common}: Improve code formatting
Change-Id: I879ac7b558781d559a65c97fc8b914ecc4ad3f0d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/39927 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/superio/acpi/pnp_generic.asl M src/superio/acpi/pnp_uart.asl M src/superio/common/generic.c 3 files changed, 3 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/superio/acpi/pnp_generic.asl b/src/superio/acpi/pnp_generic.asl index cb92a5d..afec200 100644 --- a/src/superio/acpi/pnp_generic.asl +++ b/src/superio/acpi/pnp_generic.asl @@ -13,7 +13,7 @@ * SUPERIO_PNP_LDN The logical device number on the Super I/O * chip for this device (required) * SUPERIO_PNP_DDN A string literal that identifies the dos device - * name (DDN) of this device (e.g. "COM1", optional) + * name (DDN) of this device (e.g. "COM1", optional) * SUPERIO_PNP_PM_REG Identifier of a 1-bit register to power down * the logical device (optional) * SUPERIO_PNP_PM_VAL The value for SUPERIO_PNP_PM_REG to power the logical diff --git a/src/superio/acpi/pnp_uart.asl b/src/superio/acpi/pnp_uart.asl index 859430e..751f955 100644 --- a/src/superio/acpi/pnp_uart.asl +++ b/src/superio/acpi/pnp_uart.asl @@ -12,7 +12,7 @@ * SUPERIO_UART_LDN The logical device number on the Super I/O * chip for this UART (required) * SUPERIO_UART_DDN A string literal that identifies the dos device - * name (DDN) of this uart (e.g. "COM1", optional) + * name (DDN) of this uart (e.g. "COM1", optional) * SUPERIO_UART_PM_REG Identifier of a 1-bit register to power down * the UART (optional) * SUPERIO_UART_PM_VAL The value for SUPERIO_UART_PM_REG to power the logical diff --git a/src/superio/common/generic.c b/src/superio/common/generic.c index de78199..809f886 100644 --- a/src/superio/common/generic.c +++ b/src/superio/common/generic.c @@ -37,8 +37,7 @@ const char *name = acpi_device_name(dev);
if (!scope || !name) { - printk(BIOS_ERR, "%s: Missing ACPI path/scope\n", - dev_path(dev)); + printk(BIOS_ERR, "%s: Missing ACPI path/scope\n", dev_path(dev)); return; }
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39927 )
Change subject: superio/{acpi,common}: Improve code formatting ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1960 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1959 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1958
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)