HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44936 )
Change subject: mb/*/Kconfig: Drop redundant 'select DRIVERS_INTEL_WIFI' ......................................................................
mb/*/Kconfig: Drop redundant 'select DRIVERS_INTEL_WIFI'
DRIVERS_INTEL_WIFI is already set to yes.
Change-Id: I09f628a9c1feb8992b6fe7c7ca93c75243ffc0f1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/glados/Kconfig.name M src/mainboard/google/reef/Kconfig M src/mainboard/system76/lemp9/Kconfig 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/44936/1
diff --git a/src/mainboard/google/glados/Kconfig.name b/src/mainboard/google/glados/Kconfig.name index 5162e48..5b1c383 100644 --- a/src/mainboard/google/glados/Kconfig.name +++ b/src/mainboard/google/glados/Kconfig.name @@ -10,7 +10,6 @@ config BOARD_GOOGLE_CAROLINE bool "-> Caroline (Samsung Chromebook Pro)" select BOARD_GOOGLE_BASEBOARD_GLADOS - select DRIVERS_INTEL_WIFI select DSAR_ENABLE select NHLT_SSM4567 if INCLUDE_NHLT_BLOBS select SAR_ENABLE diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index 2455101..df1d8c4 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -18,7 +18,6 @@ select MAINBOARD_HAS_I2C_TPM_CR50 select MAINBOARD_HAS_TPM2 select GOOGLE_SMBIOS_MAINBOARD_VERSION - select DRIVERS_INTEL_WIFI select USE_SAR select SAR_ENABLE select DSAR_ENABLE diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index 71f9fe5..ef7c89a 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -3,7 +3,6 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 - select DRIVERS_INTEL_WIFI select EC_SYSTEM76_EC select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44936 )
Change subject: mb/*/Kconfig: Drop redundant 'select DRIVERS_INTEL_WIFI' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44936/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44936/1//COMMIT_MSG@7 PS1, Line 7: select DRIVERS_INTEL_WIFI' : : DRIVERS_INTEL_WIFI is already set to yes. defaulting to yes is not the same as 'select'. With select you can't change it to 'no' anymore, which is probably the intention here?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44936 )
Change subject: mb/*/Kconfig: Drop redundant 'select DRIVERS_INTEL_WIFI' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44936/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44936/1//COMMIT_MSG@7 PS1, Line 7: select DRIVERS_INTEL_WIFI' : : DRIVERS_INTEL_WIFI is already set to yes.
defaulting to yes is not the same as 'select'. […]
While Arthur is right about the behaviour, I agree with Elyes that it shouldn't be enforced - at least for systems, where wifi is optional (lemp9 or it's base clevo l140 could be bought without wifi).
I'd say it could be enforced for mainboards where the wifi stuff is soldered on-board (is there any?)
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44936 )
Change subject: mb/*/Kconfig: Drop redundant 'select DRIVERS_INTEL_WIFI' ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44936 )
Change subject: mb/*/Kconfig: Drop redundant 'select DRIVERS_INTEL_WIFI' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44936/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44936/1//COMMIT_MSG@7 PS1, Line 7: select DRIVERS_INTEL_WIFI' : : DRIVERS_INTEL_WIFI is already set to yes.
While Arthur is right about the behaviour, I agree with Elyes that it shouldn't be enforced - at lea […]
Done
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44936 )
Change subject: mb/*/Kconfig: Drop redundant 'select DRIVERS_INTEL_WIFI' ......................................................................
mb/*/Kconfig: Drop redundant 'select DRIVERS_INTEL_WIFI'
DRIVERS_INTEL_WIFI is already set to yes.
Change-Id: I09f628a9c1feb8992b6fe7c7ca93c75243ffc0f1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44936 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner --- M src/mainboard/google/glados/Kconfig.name M src/mainboard/google/reef/Kconfig M src/mainboard/system76/lemp9/Kconfig 3 files changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/google/glados/Kconfig.name b/src/mainboard/google/glados/Kconfig.name index 5162e48..5b1c383 100644 --- a/src/mainboard/google/glados/Kconfig.name +++ b/src/mainboard/google/glados/Kconfig.name @@ -10,7 +10,6 @@ config BOARD_GOOGLE_CAROLINE bool "-> Caroline (Samsung Chromebook Pro)" select BOARD_GOOGLE_BASEBOARD_GLADOS - select DRIVERS_INTEL_WIFI select DSAR_ENABLE select NHLT_SSM4567 if INCLUDE_NHLT_BLOBS select SAR_ENABLE diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index 2455101..df1d8c4 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -18,7 +18,6 @@ select MAINBOARD_HAS_I2C_TPM_CR50 select MAINBOARD_HAS_TPM2 select GOOGLE_SMBIOS_MAINBOARD_VERSION - select DRIVERS_INTEL_WIFI select USE_SAR select SAR_ENABLE select DSAR_ENABLE diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index 71f9fe5..ef7c89a 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -3,7 +3,6 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 - select DRIVERS_INTEL_WIFI select EC_SYSTEM76_EC select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44936 )
Change subject: mb/*/Kconfig: Drop redundant 'select DRIVERS_INTEL_WIFI' ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44936/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44936/1//COMMIT_MSG@7 PS1, Line 7: select DRIVERS_INTEL_WIFI' : : DRIVERS_INTEL_WIFI is already set to yes.
Done
How was this done? Did you answer your own question?
I think the question was right, btw. Is it it soldered-down? If we don't know, please revert.
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)