Change in coreboot[master]: sc7280: Add target specific GPIO pin definitions - coreboot-gerrit

31 May 2021


      Attention is currently required from: Ravi kumar, Shelley Chen, Taniya Das, mturney mturney, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55077 )
Change subject: sc7280: Add target specific GPIO pin definitions
......................................................................
Patch Set 2:
(1 comment)
File src/soc/qualcomm/sc7280/include/soc/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120380):
https://review.coreboot.org/c/coreboot/+/55077/comment/86c26e6b_beeeb24b 
PS2, Line 10: #define PIN(index, func1, func2, func3, func4) \
Macros with complex values should be enclosed in parentheses
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63bcaed78a6eeb0e6fad857b89d40181613e50cc
Gerrit-Change-Number: 55077
Gerrit-PatchSet: 2
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Taniya Das tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Taniya Das tdas@codeaurora.org
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Mon, 31 May 2021 15:45:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment