Change in ...coreboot[master]: mb/google/fizz/variants/karma: Clear GPP_B4 when entering S5 - coreboot-gerrit

1 Apr 2019


      Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29796 )
Change subject: mb/google/fizz/variants/karma: Clear GPP_B4 when entering S5
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
LGTM but I'd prefer somebody who knows fizz/karma better to +2 it.
https://review.coreboot.org/#/c/29796/2/src/mainboard/google/fizz/variants/k... 
File src/mainboard/google/fizz/variants/karma/smihandler.c:
https://review.coreboot.org/#/c/29796/2/src/mainboard/google/fizz/variants/k... 
PS2, Line 4: 2018
...
2019
This CL is from November, so 2018 is correct
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65deb33a45fdc0c0ce64deaa29c2790029dc1d12
Gerrit-Change-Number: 29796
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 01 Apr 2019 08:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Zhuohao Lee zhuohao@chromium.org
Gerrit-MessageType: comment