Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71265 )
Change subject: drivers/pc80/vga: Add API to write multi-line video message
......................................................................
Patch Set 8:
(1 comment)
File src/drivers/pc80/vga/vga.c:
https://review.coreboot.org/c/coreboot/+/71265/comment/e812c728_196b3f96
PS3, Line 303: memcpy(str, string, strlen(string));
Yes, I agree. […]
Maybe it's overkill, but we could have an utility to format the text at build time, e.g. generating a .c file with arrays of strings which are centered with spaces.
(brain whirring noises)
Yes, it *is* overkill...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71265
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib837e4deeba9b84038a91c93a68f03cee3474f9b
Gerrit-Change-Number: 71265
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Mon, 02 Jan 2023 13:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment