Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Morgan Jang.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52091 )
Change subject: mb/ocp/deltalake: enable SOL console via Kconfig
......................................................................
Patch Set 6: Verified+1
(1 comment)
File src/mainboard/ocp/deltalake/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127548):
https://review.coreboot.org/c/coreboot/+/52091/comment/efb42553_55f69af4
PS6, Line 45: (1 << 28) | (1 << 16) | (1 << 17));
code indent should use tabs where possible
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52091
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida0632c6d5a3c8a951bf84600e06e394a2bdf022
Gerrit-Change-Number: 52091
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Comment-Date: Mon, 06 Sep 2021 21:56:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment