Change in coreboot[master]: Documentation/contributing/coding_style: remove bug-causing rule - coreboot-gerrit

26 Mar 2021


      Attention is currently required from: Nico Huber, Stefan Reinauer, Paul Menzel, Julius Werner, Angel Pons, Felix Held.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51825 )
Change subject: Documentation/contributing/coding_style: remove bug-causing rule
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
https://lore.kernel. […]
For reference, Patrick brought this up in 2018 ("Proposing a change to Coding Style" [1]) when he ran into a bug in the Chrome EC codebase due to braces.
The discussion was brought up again in 2019 ("Re: More coding style change proposals" [2]) where Jacob Garber cited a bug in Apple's SSL caused by braces [3]. Also mentioned was that tools like Coverity and clang can warn of misleading braces, though I wonder how useful that is if somebody isn't paying very close attention.
Just wanted to mention that yes, there are documented cases where missing braces have caused issues in the past. There were also multiple discussions on the mailing list - this is not something that came from a secretive cabal meeting on a Wednesday during the wee hours between breakfast and lunch.
[1] https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/GSQR...
[2] https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/ZT6N...
[3] https://www.imperialviolet.org/2014/02/22/applebug.html.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51825
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06422d4f6ce448766e50c7684bbeaa55ae825899
Gerrit-Change-Number: 51825
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer reinauer@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Stefan Reinauer reinauer@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 26 Mar 2021 07:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment