Attention is currently required from: Nico Huber, Stefan Reinauer, Paul Menzel, Julius Werner, Angel Pons, Felix Held.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    https://lore.kernel. […]

    For reference, Patrick brought this up in 2018 ("Proposing a change to Coding Style" [1]) when he ran into a bug in the Chrome EC codebase due to braces.

    The discussion was brought up again in 2019 ("Re: More coding style change proposals" [2]) where Jacob Garber cited a bug in Apple's SSL caused by braces [3]. Also mentioned was that tools like Coverity and clang can warn of misleading braces, though I wonder how useful that is if somebody isn't paying very close attention.

    Just wanted to mention that yes, there are documented cases where missing braces have caused issues in the past. There were also multiple discussions on the mailing list - this is not something that came from a secretive cabal meeting on a Wednesday during the wee hours between breakfast and lunch.

    [1] https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/GSQRNOSLWA2U5XN3CTHQGCY3LPXPHCBY/
    [2] https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/ZT6NKBKXNUE3NCUMQOBWTXHFWYTFGR2M/
    [3] https://www.imperialviolet.org/2014/02/22/applebug.html.

To view, visit change 51825. To unsubscribe, or for help writing mail filters, visit settings.