Attention is currently required from: Daniel Kurtz, Martin Roth, Paul Menzel. Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56100 )
Change subject: grunt/treeya: add Realtek ALC5682 codec support ......................................................................
Patch Set 4:
(4 comments)
File src/mainboard/google/kahlee/variants/treeya/audio.c:
https://review.coreboot.org/c/coreboot/+/56100/comment/1250fe28_48cfea6f PS2, Line 22: 0xfedc2000
src/soc/amd/stoneyridge/include/soc/iomap. […]
Update in patchset 4.
https://review.coreboot.org/c/coreboot/+/56100/comment/64e52573_18bbe8fa PS2, Line 24: }
Can one of the checks be moved into the do-while condition? […]
Hi Paul Update in patchset 4, Is this what you want to change?
https://review.coreboot.org/c/coreboot/+/56100/comment/af167c61_25a42b48 PS2, Line 27: return;
Can’t you return already above? Maybe also print an error?
Hi Paul Update in patchset 4, Is this what you want to change?
https://review.coreboot.org/c/coreboot/+/56100/comment/7924464e_eaa9fbf0 PS2, Line 32: 0x1a
As long as we're updating things, we could turn this into a #define. […]
Update in patchset 4.
-
Kevin Chang (Code Review)