Change in coreboot[master]: mb/google/dedede/var/magolor: Generate SPD ID for supported parts

[Ren Kuo (Code Review)]

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

mb/google/dedede/var/magolor: Generate SPD ID for supported parts

Add supported memory parts in the mem_list_variant.txt and generate the
SPD ID for the parts.The memory parts being added are:
MT53E512M32D2NP-046 WT:E
K4U6E3S4AA-MGCR
H9HCNNNBKMMLXR-NEE
MT53E1G32D2NP-046 WT:A
K4UBE3D4AA-MGCR

BUG=None
TEST=Build the magolor board

Signed-off-by: Ren Kuo 
Change-Id: I3348b7fbeff038b85e7d3c9137517e05a35bf3dd
---
A src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc
A src/mainboard/google/dedede/variants/magolor/memory/dram_id.generated.txt
A src/mainboard/google/dedede/variants/magolor/memory/mem_list_variant.txt
3 files changed, 18 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/44408/1

diff --git a/src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc b/src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc
new file mode 100644
index 0000000..bab4f2a
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc
@@ -0,0 +1,7 @@
+## SPDX-License-Identifier: GPL-2.0-or-later
+## This is an auto-generated file. Do not edit!!
+
+SPD_SOURCES =
+SPD_SOURCES += spd-1.hex      # ID = 0(0b0000)  Parts = MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE
+SPD_SOURCES += spd-4.hex      # ID = 1(0b0001)  Parts = MT53E1G32D2NP-046 WT:A
+SPD_SOURCES += spd-3.hex      # ID = 2(0b0010)  Parts = K4UBE3D4AA-MGCR
diff --git a/src/mainboard/google/dedede/variants/magolor/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/magolor/memory/dram_id.generated.txt
new file mode 100644
index 0000000..100c322
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/magolor/memory/dram_id.generated.txt
@@ -0,0 +1,6 @@
+DRAM Part Name                 ID to assign
+MT53E512M32D2NP-046 WT:E       0 (0000)
+K4U6E3S4AA-MGCR                0 (0000)
+H9HCNNNBKMMLXR-NEE             0 (0000)
+MT53E1G32D2NP-046 WT:A         1 (0001)
+K4UBE3D4AA-MGCR                2 (0010)
diff --git a/src/mainboard/google/dedede/variants/magolor/memory/mem_list_variant.txt b/src/mainboard/google/dedede/variants/magolor/memory/mem_list_variant.txt
new file mode 100644
index 0000000..f05a5af
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/magolor/memory/mem_list_variant.txt
@@ -0,0 +1,5 @@
+MT53E512M32D2NP-046 WT:E
+K4U6E3S4AA-MGCR
+H9HCNNNBKMMLXR-NEE
+MT53E1G32D2NP-046 WT:A
+K4UBE3D4AA-MGCR

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

Patch Set 1: Code-Review+1

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

Patch Set 1:

deprecated by https://review.coreboot.org/c/coreboot/+/43989?

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

Patch Set 1:
> Patch Set 1:
>
> deprecated by https://review.coreboot.org/c/coreboot/+/43989?

Ren reminded me that Mag"A"lar in CL above would be typo for magolor here?

[Marco Chen (Code Review)]

Marco Chen has uploaded a new patch set (#2) to the change originally created by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

mb/google/dedede/var/magolor: Generate SPD ID for supported parts

Add supported memory parts in the mem_list_variant.txt and generate the
SPD ID for the parts. The memory parts being added are:
MT53E512M32D2NP-046 WT:E
K4U6E3S4AA-MGCR
H9HCNNNBKMMLXR-NEE
MT53E1G32D2NP-046 WT:A
K4UBE3D4AA-MGCR

BUG=None
TEST=Build the magolor board

Signed-off-by: Ren Kuo 
Change-Id: I3348b7fbeff038b85e7d3c9137517e05a35bf3dd
---
A src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc
A src/mainboard/google/dedede/variants/magolor/memory/dram_id.generated.txt
A src/mainboard/google/dedede/variants/magolor/memory/mem_list_variant.txt
3 files changed, 18 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/44408/2

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

Patch Set 2: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

Patch Set 2:
> Patch Set 1:
> > Patch Set 1:
> >
> > deprecated by https://review.coreboot.org/c/coreboot/+/43989?
>
> Ren reminded me that Mag"A"lar in CL above would be typo for magolor here?

<Sigh> Sorry for the typo. Can you please remove that folder then as part of this CL or a follow-up CL?

Or better move the files from that folder to here.

[Ren Kuo (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Marco Chen, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44408

to look at the new patch set (#3).

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

mb/google/dedede/var/magolor: Generate SPD ID for supported parts

Add supported memory parts in the mem_list_variant.txt and generate the
SPD ID for the parts. The memory parts being added are:
MT53E512M32D2NP-046 WT:E
K4U6E3S4AA-MGCR
H9HCNNNBKMMLXR-NEE
MT53E1G32D2NP-046 WT:A
K4UBE3D4AA-MGCR

And also remove the deprecated by cl#43989
https://review.coreboot.org/c/coreboot/+/43989

BUG=None
TEST=Build the magolor board

Signed-off-by: Ren Kuo 
Change-Id: I3348b7fbeff038b85e7d3c9137517e05a35bf3dd
---
R src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc
R src/mainboard/google/dedede/variants/magolor/memory/dram_id.generated.txt
R src/mainboard/google/dedede/variants/magolor/memory/mem_list_variant.txt
3 files changed, 0 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/44408/3

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

Patch Set 3: Code-Review+1
> Patch Set 1:
>
> deprecated by https://review.coreboot.org/c/coreboot/+/43989?

it's a different project name. the folder is magolor here and "magalor"

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

Patch Set 3:
> Patch Set 2:
> > Patch Set 1:
> > > Patch Set 1:
> > >
> > > deprecated by https://review.coreboot.org/c/coreboot/+/43989?
> >
> > Ren reminded me that Mag"A"lar in CL above would be typo for magolor here?
>
> <Sigh> Sorry for the typo. Can you please remove that folder then as part of this CL or a follow-up CL?
>
> Or better move the files from that folder to here.

OK. update it in patch set 2

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

Patch Set 3:
> Patch Set 3:
> > Patch Set 2:
> > > Patch Set 1:
> > > > Patch Set 1:
> > > >
> > > > deprecated by https://review.coreboot.org/c/coreboot/+/43989?
> > >
> > > Ren reminded me that Mag"A"lar in CL above would be typo for magolor here?
> >
> > <Sigh> Sorry for the typo. Can you please remove that folder then as part of this CL or a follow-up CL?
> >
> > Or better move the files from that folder to here.
>
> OK. update it in patch set 3

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

Patch Set 3: Code-Review+2

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

Patch Set 3: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44408 )

Change subject: mb/google/dedede/var/magolor: Generate SPD ID for supported parts
......................................................................

mb/google/dedede/var/magolor: Generate SPD ID for supported parts

Add supported memory parts in the mem_list_variant.txt and generate the
SPD ID for the parts. The memory parts being added are:
MT53E512M32D2NP-046 WT:E
K4U6E3S4AA-MGCR
H9HCNNNBKMMLXR-NEE
MT53E1G32D2NP-046 WT:A
K4UBE3D4AA-MGCR

And also remove the deprecated by cl#43989
https://review.coreboot.org/c/coreboot/+/43989

BUG=None
TEST=Build the magolor board

Signed-off-by: Ren Kuo 
Change-Id: I3348b7fbeff038b85e7d3c9137517e05a35bf3dd
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44408
Reviewed-by: Karthik Ramasubramanian 
Reviewed-by: Marco Chen 
Tested-by: build bot (Jenkins) 
---
R src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc
R src/mainboard/google/dedede/variants/magolor/memory/dram_id.generated.txt
R src/mainboard/google/dedede/variants/magolor/memory/mem_list_variant.txt
3 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Ren Kuo: Looks good to me, but someone else must approve
  Marco Chen: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/magalor/memory/Makefile.inc b/src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc
similarity index 100%
rename from src/mainboard/google/dedede/variants/magalor/memory/Makefile.inc
rename to src/mainboard/google/dedede/variants/magolor/memory/Makefile.inc
diff --git a/src/mainboard/google/dedede/variants/magalor/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/magolor/memory/dram_id.generated.txt
similarity index 100%
rename from src/mainboard/google/dedede/variants/magalor/memory/dram_id.generated.txt
rename to src/mainboard/google/dedede/variants/magolor/memory/dram_id.generated.txt
diff --git a/src/mainboard/google/dedede/variants/magalor/memory/mem_list_variant.txt b/src/mainboard/google/dedede/variants/magolor/memory/mem_list_variant.txt
similarity index 100%
rename from src/mainboard/google/dedede/variants/magalor/memory/mem_list_variant.txt
rename to src/mainboard/google/dedede/variants/magolor/memory/mem_list_variant.txt