Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48495 )
Change subject: mb/google/volteer: Update drobit device tree ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48495/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/drobit/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48495/3/src/mainboard/google/voltee... PS3, Line 25: device pci 04.0 on : chip drivers/intel/dptf : ## Active Policy : register "policies.active" = "{ : [0] = {.target = DPTF_TEMP_SENSOR_3, : .thresholds = {TEMP_PCT(57, 90), : TEMP_PCT(47, 80), : TEMP_PCT(40, 70), : TEMP_PCT(36, 60), : TEMP_PCT(34, 50), : TEMP_PCT(30, 40),}}}" : : ## Passive Policy : register "policies.passive" = "{ : [0] = DPTF_PASSIVE(CPU, CPU, 95, 6000), : [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 75, 6000), : [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 75, 6000), : [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 75, 6000), : [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 75, 6000)}" : : ## Critical Policy : register "policies.critical" = "{ : [0] = DPTF_CRITICAL(CPU, 100, SHUTDOWN), : [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 80, SHUTDOWN), : [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 80, SHUTDOWN), : [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 80, SHUTDOWN), : [4] = DPTF_CRITICAL(TEMP_SENSOR_3, 80, SHUTDOWN)}" : : ## Power Limits Control : # 3-15W PL1 in 200mW increments, avg over 28-32s interval : # PL2 is 15-51W, avg over 28-32s interval : register "controls.power_limits" = "{ : .pl1 = {.min_power = 3000, : .max_power = 15000, : .time_window_min = 28 * MSECS_PER_SEC, : .time_window_max = 32 * MSECS_PER_SEC, : .granularity = 200,}, : .pl2 = {.min_power = 15000, : .max_power = 51000, : .time_window_min = 28 * MSECS_PER_SEC, : .time_window_max = 32 * MSECS_PER_SEC, : .granularity = 1000,}}" : : ## Fan Performance Control (Percent, Speed, Noise, Power) : register "controls.fan_perf" = "{ : [0] = { 90, 5200, 220, 2200, }, : [1] = { 80, 4900, 180, 1800, }, : [2] = { 70, 4600, 145, 1450, }, : [3] = { 60, 4200, 115, 1150, }, : [4] = { 50, 3800, 90, 900, }, : [5] = { 40, 3400, 55, 550, }, : [6] = { 30, 2900, 30, 300, }, : [7] = { 20, 2300, 15, 150, }, : [8] = { 10, 1600, 10, 100, }, : [9] = { 0, 0, 0, 50, }}" : : # Fan options : register "options.fan.fine_grained_control" = "1" : register "options.fan.step_size" = "2" : : device generic 0 on end : end : end # DPTF 0x9A03
Is this fine tuned for the Drobit? If not, i would suggest to submit it later.
Done