Attention is currently required from: Furquan Shaikh, Rizwan Qureshi, Tim Wawrzynczak, Sridhar Siricilla, Aseda Aboagye, Andrey Petrov, Patrick Rudolph, Karthik Ramasubramanian. Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57295 )
Change subject: soc/intel/common/cse: Add argument for CSE fixed client addr ......................................................................
Patch Set 9:
(5 comments)
File src/soc/intel/apollolake/cse.c:
https://review.coreboot.org/c/coreboot/+/57295/comment/10095d31_e6c3459f PS7, Line 82: if (!heci_send_receive(&msg, sizeof(msg), &rmsg, &reply_size , HECI_MKHI_ADDR)) {
space prohibited before that ',' (ctx:WxW)
Please fix.
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/57295/comment/033306c0_37f01bea PS7, Line 390: * In case of error heci_reset() may be requiered.
'requiered' may be misspelled - perhaps 'required'?
Please fix.
https://review.coreboot.org/c/coreboot/+/57295/comment/eb03df23_32322ac2 PS7, Line 501: * In case of error heci_reset() may be requiered.
'requiered' may be misspelled - perhaps 'required'?
Please fix.
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/57295/comment/13b77072_4e59d926 PS6, Line 38: if (!heci_send_receive(&msg, sizeof(msg), &reply, &reply_sz, HECI_MEI_ADDR)) {
Similar thing can be done inside APL cse_eop.c. […]
Done
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/57295/comment/14958731_79195bb6 PS6, Line 152: * rcv_msg of size rcv_sz
Nit: Add "from BIOS_HOST_ADDR to cse_addr"
Done