Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85847?usp=email )
(
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/hp/pro_3x00_series: Remove unused ACPI brightness control ......................................................................
mb/hp/pro_3x00_series: Remove unused ACPI brightness control
These lines are not needed because this mainboard does not have an integrated display to control.
Tested on HP Pro 3400 Series.
Change-Id: Id39cd18713cc596eb2c92e028dad480fe7de8ef2 Signed-off-by: Vesek venda.straka@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85847 Reviewed-by: Nicholas Chin nic.c3.14@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/hp/pro_3x00_series/dsdt.asl 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: Nicholas Chin: Looks good to me, approved build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/hp/pro_3x00_series/dsdt.asl b/src/mainboard/hp/pro_3x00_series/dsdt.asl index cee4939..9b86d2a 100644 --- a/src/mainboard/hp/pro_3x00_series/dsdt.asl +++ b/src/mainboard/hp/pro_3x00_series/dsdt.asl @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB -#define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB #include <acpi/acpi.h>
DefinitionBlock( @@ -23,7 +21,6 @@ Device (_SB.PCI0) { #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> - #include <drivers/intel/gma/acpi/default_brightness_levels.asl> #include <southbridge/intel/bd82x6x/acpi/pch.asl> } }