Change in coreboot[master]: soc/amd/picasso: Get rid of chip.h inclusion from southbridge.h
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40822 )
Change subject: soc/amd/picasso: Get rid of chip.h inclusion from southbridge.h ......................................................................
soc/amd/picasso: Get rid of chip.h inclusion from southbridge.h
southbridge.h does not really need chip.h. So, this change removes the inclusion of chip.h from it.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I09c87b975ecd5f7798da8dd858be0c729aef42de --- M src/soc/amd/picasso/include/soc/southbridge.h 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/40822/1
diff --git a/src/soc/amd/picasso/include/soc/southbridge.h b/src/soc/amd/picasso/include/soc/southbridge.h index a134245..cf1d1247 100644 --- a/src/soc/amd/picasso/include/soc/southbridge.h +++ b/src/soc/amd/picasso/include/soc/southbridge.h @@ -8,7 +8,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <soc/iomap.h> -#include "chip.h"
/* * AcpiMmio Region
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40822 )
Change subject: soc/amd/picasso: Get rid of chip.h inclusion from southbridge.h ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40822 )
Change subject: soc/amd/picasso: Get rid of chip.h inclusion from southbridge.h ......................................................................
Patch Set 1: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40822 )
Change subject: soc/amd/picasso: Get rid of chip.h inclusion from southbridge.h ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40822 )
Change subject: soc/amd/picasso: Get rid of chip.h inclusion from southbridge.h ......................................................................
soc/amd/picasso: Get rid of chip.h inclusion from southbridge.h
southbridge.h does not really need chip.h. So, this change removes the inclusion of chip.h from it.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I09c87b975ecd5f7798da8dd858be0c729aef42de Reviewed-on: https://review.coreboot.org/c/coreboot/+/40822 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/include/soc/southbridge.h 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/picasso/include/soc/southbridge.h b/src/soc/amd/picasso/include/soc/southbridge.h index a134245..cf1d1247 100644 --- a/src/soc/amd/picasso/include/soc/southbridge.h +++ b/src/soc/amd/picasso/include/soc/southbridge.h @@ -8,7 +8,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <soc/iomap.h> -#include "chip.h"
/* * AcpiMmio Region
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
Furquan Shaikh (Code Review)
-
Raul Rangel (Code Review)