Change in coreboot[master]: mb/google/nipperkin: Disable PSPP for WLAN - coreboot-gerrit

12 Apr 2022


      Attention is currently required from: Raul Rangel, Rob Barnes, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63593 )
Change subject: mb/google/nipperkin: Disable PSPP for WLAN
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/mainboard/google/guybrush/variants/nipperkin/variant.c:
https://review.coreboot.org/c/coreboot/+/63593/comment/ad0a12ce_35a8f70b 
PS1, Line 17: 		memset(dxio_descriptors[WLAN].port_params, 0,
should this only be done for board_version >= 3 or for all board revisions?
i'd also use a loop instead of a memset, but either works and i don't have a too strong preference here
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63593
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38f05b92ace4aba61163194a6a638915882b8871
Gerrit-Change-Number: 63593
Gerrit-PatchSet: 1
Gerrit-Owner: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-CC: Bhanu Prakash Maiya bhanumaiya@google.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 20:38:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment