Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41097 )
Change subject: mb/asus/p2b: Add p3b-f IRQ routing to DSDT ......................................................................
mb/asus/p2b: Add p3b-f IRQ routing to DSDT
Change-Id: Ie4d24eee1cffd65707887dd621e3de873d20cf01 Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b/dsdt.asl 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/41097/1
diff --git a/src/mainboard/asus/p2b/dsdt.asl b/src/mainboard/asus/p2b/dsdt.asl index 0c415da..88be9ba 100644 --- a/src/mainboard/asus/p2b/dsdt.asl +++ b/src/mainboard/asus/p2b/dsdt.asl @@ -149,6 +149,17 @@ Package (0x04) { 0x000CFFFF, 2, LNKC, 0 }, Package (0x04) { 0x000CFFFF, 3, LNKD, 0 },
+#if CONFIG(BOARD_ASUS_P3B_F) + Package (0x04) { 0x000DFFFF, 0, LNKD, 0 }, + Package (0x04) { 0x000DFFFF, 1, LNKA, 0 }, + Package (0x04) { 0x000DFFFF, 2, LNKB, 0 }, + Package (0x04) { 0x000DFFFF, 3, LNKC, 0 }, + + Package (0x04) { 0x000EFFFF, 0, LNKC, 0 }, + Package (0x04) { 0x000EFFFF, 1, LNKD, 0 }, + Package (0x04) { 0x000EFFFF, 2, LNKA, 0 }, + Package (0x04) { 0x000EFFFF, 3, LNKB, 0 }, +#endif }) #include <northbridge/intel/i440bx/acpi/sb_pci0_crs.asl> #include <southbridge/intel/i82371eb/acpi/isabridge.asl>
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41097 )
Change subject: mb/asus/p2b: Add p3b-f IRQ routing to DSDT ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41097 )
Change subject: mb/asus/p2b: Add p3b-f IRQ routing to DSDT ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41097 )
Change subject: mb/asus/p2b: Add p3b-f IRQ routing to DSDT ......................................................................
mb/asus/p2b: Add p3b-f IRQ routing to DSDT
Change-Id: Ie4d24eee1cffd65707887dd621e3de873d20cf01 Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41097 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asus/p2b/dsdt.asl 1 file changed, 11 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/asus/p2b/dsdt.asl b/src/mainboard/asus/p2b/dsdt.asl index c1ac599..e1bda17 100644 --- a/src/mainboard/asus/p2b/dsdt.asl +++ b/src/mainboard/asus/p2b/dsdt.asl @@ -141,6 +141,17 @@ Package (0x04) { 0x000CFFFF, 2, LNKC, 0 }, Package (0x04) { 0x000CFFFF, 3, LNKD, 0 },
+#if CONFIG(BOARD_ASUS_P3B_F) + Package (0x04) { 0x000DFFFF, 0, LNKD, 0 }, + Package (0x04) { 0x000DFFFF, 1, LNKA, 0 }, + Package (0x04) { 0x000DFFFF, 2, LNKB, 0 }, + Package (0x04) { 0x000DFFFF, 3, LNKC, 0 }, + + Package (0x04) { 0x000EFFFF, 0, LNKC, 0 }, + Package (0x04) { 0x000EFFFF, 1, LNKD, 0 }, + Package (0x04) { 0x000EFFFF, 2, LNKA, 0 }, + Package (0x04) { 0x000EFFFF, 3, LNKB, 0 }, +#endif }) #include <northbridge/intel/i440bx/acpi/sb_pci0_crs.asl> #include <southbridge/intel/i82371eb/acpi/isabridge.asl>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41097 )
Change subject: mb/asus/p2b: Add p3b-f IRQ routing to DSDT ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4556 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4555 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4554 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4553
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Keith Hui (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)