Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31102
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
soc/intel/cannonlake: Enable RTC support
Turn on RTC support for Cannonlake SOC.
BUG=b:123372643 TEST=build and boot up on sarien platform, run cbmem -c, the "timestamp unavilable" error message gone.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I34e73f6508bd83e2c8edf740c33eb253bffa5e6d --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/31102/1
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index f8193cd..6bd8a7f 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -49,6 +49,7 @@ select POSTCAR_CONSOLE select POSTCAR_STAGE select REG_SCRIPT + select RTC select SMM_TSEG select SMP select SOC_AHCI_PORT_IMPLEMENTED_INVERT @@ -62,6 +63,7 @@ select SOC_INTEL_COMMON_BLOCK_CPU_MPINIT select SOC_INTEL_COMMON_BLOCK_GSPI_VERSION_2 select SOC_INTEL_COMMON_BLOCK_HDA + select SOC_INTEL_COMMON_BLOCK_RTC select SOC_INTEL_COMMON_BLOCK_SA select SOC_INTEL_COMMON_BLOCK_SMM select SOC_INTEL_COMMON_BLOCK_SMM_IO_TRAP
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 1: Code-Review+2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 1: Code-Review+2
well that was easy..
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31102/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31102/1//COMMIT_MSG@13 PS1, Line 13: unavilable unavailable
Hello Patrick Rudolph, Angel Pons, Subrata Banik, Duncan Laurie, Bora Guvendik, build bot (Jenkins), Hannah Williams, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31102
to look at the new patch set (#2).
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
soc/intel/cannonlake: Enable RTC support
Turn on RTC support for Cannonlake SOC.
BUG=b:123372643 TEST=build and boot up on sarien platform, run cbmem -c, the "timestamp unavailable" error message gone.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I34e73f6508bd83e2c8edf740c33eb253bffa5e6d --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/31102/2
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31102/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31102/1//COMMIT_MSG@13 PS1, Line 13: unavilable
unavailable
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31102/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31102/2//COMMIT_MSG@13 PS2, Line 13: unavailable" error message gone. I don't see how this is related. Are you sure the message is fixed by this commit?
https://review.coreboot.org/#/c/31102/2/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31102/2/src/soc/intel/cannonlake/Kconfig@66 PS2, Line 66: select SOC_INTEL_COMMON_BLOCK_RTC Already selected by SOC_INTEL_COMMON_PCH_BASE.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31102/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31102/2//COMMIT_MSG@13 PS2, Line 13: unavailable" error message gone.
I don't see how this is related. Are you sure the message is fixed […]
Yes, you can check drivers/elog/elog.c, without CONFIG_RTC event log can't get current time and date.
https://review.coreboot.org/#/c/31102/2/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31102/2/src/soc/intel/cannonlake/Kconfig@66 PS2, Line 66: select SOC_INTEL_COMMON_BLOCK_RTC
Already selected by SOC_INTEL_COMMON_PCH_BASE.
Good catch, yes I believe just line#52 is enough.
Hello Patrick Rudolph, Angel Pons, Subrata Banik, Duncan Laurie, Bora Guvendik, build bot (Jenkins), Hannah Williams, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31102
to look at the new patch set (#3).
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
soc/intel/cannonlake: Enable RTC support
Turn on RTC support for Cannonlake SOC.
BUG=b:123372643 TEST=build and boot up on sarien platform, run cbmem -c, the "timestamp unavailable" error message gone.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I34e73f6508bd83e2c8edf740c33eb253bffa5e6d --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/31102/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Though, would it make sense to draw `select RTC` into SOC_INTEL_COMMON_PCH_BASE, too? Or even into SOC_INTEL_ COMMON_BLOCK_RTC?
https://review.coreboot.org/#/c/31102/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31102/2//COMMIT_MSG@13 PS2, Line 13: unavailable" error message gone.
Yes, you can check drivers/elog/elog. […]
Ah, my bad. I only read `cbmem` and `timestamp` and thought it's about coreboot's timestamp feature (and cbmem showed an error). But that'd be `-t` not `-c` ;)
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig@52 PS3, Line 52: select RTC why don't you select this here
https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/pch/Kc... ?
and get rid of icl and cnl separate CLs?
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig@52 PS3, Line 52: select RTC
why don't you select this here […]
I think RTC is optional for atom, at least in hardware reduced mode, RTC is optional. By the way, so far common pch Kconfig all have SOC_INTEL_COMMON features, is that okay to move RTC there?
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig@52 PS3, Line 52: select RTC
I think RTC is optional for atom, at least in hardware reduced mode, RTC is optional. […]
CB:31112 have the changes.
Lijian Zhao has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Abandoned
CB:31112 have the changes.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig@52 PS3, Line 52: select RTC
CB:31112 have the changes.
select SOC_INTEL_COMMON_BLOCK_RTC ?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig@52 PS3, Line 52: select RTC
select SOC_INTEL_COMMON_BLOCK_RTC ?
it's already selected by SOC_INTEL_COMMON_PCH_BASE below
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
Duncan Laurie (Code Review)
-
Furquan Shaikh (Code Review)
-
Lijian Zhao (Code Review)
-
Nico Huber (Code Review)
-
Subrata Banik (Code Review)