Attention is currently required from: Alexander Couzens, Patrick Rudolph. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58752 )
Change subject: lenovo/g505s: add the PIRQ routing table ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1: Helpful comments by Arthur Heymans above (there were much more of them but some got resolved)
File src/mainboard/lenovo/g505s/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/58752/comment/82c3fe73_4181da66 PS1, Line 12: 0x1022, /* Vendor */ : 0x780e 1) Changed?
2) That's what getpir utility told me (0x1022 0x780b is 00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD] FCH SMBus Controller [1022:780b] (rev 16)) . Meanwhile, a previously used " 0x1002 0x4384 device doesn't exist on this system at all
https://review.coreboot.org/c/coreboot/+/58752/comment/bdc2bcdd_9fbe5ccc PS1, Line 62: copy_pirq_routing_table 1) Going from something dynamically generated to something static seems like a downgrade. 2) This [older] dynamic stuff never worked properly and seems to have a lot of dead code.
-
Mike Banon (Code Review)