Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49025 )
Change subject: mb/clevo/cml-u: Rework Kconfig ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/K... File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/K... PS3, Line 21: _OPTIONS nit: I don't think we really need that suffix
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/K... PS3, Line 21: onfig BOARD_CLEVO_L140CU_OPTIONS : bool : select BOARD_CLEVO_CMLU_COMMON : select EC_SYSTEM76_EC : select HAVE_SPD_IN_CBFS just an idea: we could have a separate Kconfig for each variant in variants/<variant>/Kconfig where these overrides go to. wdyt?
-
Michael Niewöhner (Code Review)