Change in coreboot[master]: Makefile: set and export SOURCE_DATE_EPOCH - coreboot-gerrit

9 Apr 2021


      Attention is currently required from: Martin Roth.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51364 )
Change subject: Makefile: set and export SOURCE_DATE_EPOCH
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File Makefile:
https://review.coreboot.org/c/coreboot/+/51364/comment/5f753bb2_3b09c305 
PS5, Line 27: SOURCE_DATE_EPOCH := $(shell $(top)/util/genbuild_h/genbuild_h.sh . | sed -n 's/^.define COREBOOT_BUILD_EPOCH>.*"(.*)".*/\1/p')
...
I don't know if there is a better approach, however build. […]
There's certainly room for optimization, but let's defer that...
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51364
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c870023d13ff4c95305c8aba1459c1fcaf18773
Gerrit-Change-Number: 51364
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Comment-Date: Fri, 09 Apr 2021 06:09:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu
Gerrit-MessageType: comment