Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Marshall Dawson, Matt DeVillier, Zheng Bao.
Patrick Rudolph has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/85628?usp=email )
Change subject: cbfstool: Do not compress the BIOS binary if A/B recovery
......................................................................
Patch Set 12:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85628/comment/df95acc3_ec59d007?usp... :
PS12, Line 7: /
I don't see the relation to A/B recovery.
From what I understand it's only necessary for `CONFIG_CBFS_VERIFICATION`
https://review.coreboot.org/c/coreboot/+/85628/comment/4d01b851_79f02500?usp... :
PS12, Line 9: verification
Who verifies the CBFS?
Does it verify before decompression?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85628?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I10db7ad44d2a92c143f46d9ee6fc7824b2ff0cc6
Gerrit-Change-Number: 85628
Gerrit-PatchSet: 12
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 23 Jan 2025 08:17:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No