Attention is currently required from: Brandon Breitenstein, Caveh Jalali, Eran Mitrani, Hannah Williams, Kapil Porwal, Subrata Banik, Sukumar Ghorai, Tarun, Tim Van Patten.
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78322?usp=email )
Change subject: mb/google/rex/var/rex: Configure cpu power limits by battery status
......................................................................
Patch Set 6:
(4 comments)
File src/mainboard/google/rex/variants/baseboard/rex/ramstage.c:
https://review.coreboot.org/c/coreboot/+/78322/comment/ab7e99d0_feb27e6d :
PS5, Line 25: p
'optimized' sounds like the preferred/nominal profile, […]
this is updated to patchset#6. please let me know if you have any suggestion.
https://review.coreboot.org/c/coreboot/+/78322/comment/8b33a615_998b4060 :
PS5, Line 41: google_chromeec_read_battery_status
shouldn't this be < 0 ?? […]
This is updated to patchset#6.
https://review.coreboot.org/c/coreboot/+/78322/comment/53ed30ad_825c804c :
PS5, Line 42: printk(BIOS_ERR, "Failed to read EC battery info\n");
I was thinking to let the boot flow goes with power_optimized_limits profile, but if you have a su […]
This is updated to patchset#6.
https://review.coreboot.org/c/coreboot/+/78322/comment/5b48876d_c4300059 :
PS5, Line 48: battery_status
isn't the battery cut-off or no battery is the major concern for us? […]
the patchset#6 is updated to consider 'no battery' and 'level_critical' cases to lower PL4 configuration. Please let me know if you have any comments. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78322?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I12fd40abda76c8e7522b06a5aee72665f32ddec8
Gerrit-Change-Number: 78322
Gerrit-PatchSet: 6
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Fri, 13 Oct 2023 22:31:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Ryu
jamie.m.ryu@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment