Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36708 )
Change subject: AGESA: Select CBMEM_STAGE_CACHE with HAVE_ACPI_RESUME ......................................................................
AGESA: Select CBMEM_STAGE_CACHE with HAVE_ACPI_RESUME
Fix regression with commit 0a4457f
lib/stage_cache: Refactor Kconfig options
AGESA platforms fail to resume from S3 suspend with CBMEM_STAGE_CACHE=n. For the time being the root cause is unknown.
Change-Id: I11db0c883b6e39473d02e92b14cb3c6302aa728e Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/amd/agesa/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/36708/1
diff --git a/src/cpu/amd/agesa/Kconfig b/src/cpu/amd/agesa/Kconfig index b1fde2d..d14eb40 100644 --- a/src/cpu/amd/agesa/Kconfig +++ b/src/cpu/amd/agesa/Kconfig @@ -27,6 +27,7 @@ select UDELAY_LAPIC select LAPIC_MONOTONIC_TIMER select SPI_FLASH if HAVE_ACPI_RESUME + select CBMEM_STAGE_CACHE if HAVE_ACPI_RESUME select SMM_ASEG select NO_FIXED_XIP_ROM_SIZE
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36708 )
Change subject: AGESA: Select CBMEM_STAGE_CACHE with HAVE_ACPI_RESUME ......................................................................
Patch Set 1:
https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/O2HBF...
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36708 )
Change subject: AGESA: Select CBMEM_STAGE_CACHE with HAVE_ACPI_RESUME ......................................................................
Patch Set 1: Code-Review+2
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36708 )
Change subject: AGESA: Select CBMEM_STAGE_CACHE with HAVE_ACPI_RESUME ......................................................................
Patch Set 1: Code-Review+2
Very good! Although, I don't know if CBMEM_STAGE_CACHE security concerns are serious enough: if yes, some people may want to be able to sacrifice ACPI_RESUME (I could try to make these options selectable in a follow-up commit if really necessary)
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36708 )
Change subject: AGESA: Select CBMEM_STAGE_CACHE with HAVE_ACPI_RESUME ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36708 )
Change subject: AGESA: Select CBMEM_STAGE_CACHE with HAVE_ACPI_RESUME ......................................................................
AGESA: Select CBMEM_STAGE_CACHE with HAVE_ACPI_RESUME
Fix regression with commit 0a4457f
lib/stage_cache: Refactor Kconfig options
AGESA platforms fail to resume from S3 suspend with CBMEM_STAGE_CACHE=n. For the time being the root cause is unknown.
Change-Id: I11db0c883b6e39473d02e92b14cb3c6302aa728e Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36708 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Mike Banon mikebdp2@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de --- M src/cpu/amd/agesa/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Arthur Heymans: Looks good to me, approved Mike Banon: Looks good to me, approved
diff --git a/src/cpu/amd/agesa/Kconfig b/src/cpu/amd/agesa/Kconfig index b1fde2d..d14eb40 100644 --- a/src/cpu/amd/agesa/Kconfig +++ b/src/cpu/amd/agesa/Kconfig @@ -27,6 +27,7 @@ select UDELAY_LAPIC select LAPIC_MONOTONIC_TIMER select SPI_FLASH if HAVE_ACPI_RESUME + select CBMEM_STAGE_CACHE if HAVE_ACPI_RESUME select SMM_ASEG select NO_FIXED_XIP_ROM_SIZE
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36708 )
Change subject: AGESA: Select CBMEM_STAGE_CACHE with HAVE_ACPI_RESUME ......................................................................
Patch Set 2:
CB:37683 is possibly the fix.
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)
-
Mike Banon (Code Review)
-
Nico Huber (Code Review)