Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61627 )
Change subject: drivers/pcie/generic: Add new pcie generic chip driver
......................................................................
Patch Set 2:
(2 comments)
File src/drivers/pcie/generic/Kconfig:
https://review.coreboot.org/c/coreboot/+/61627/comment/b3be6807_70bbcc19
PS1, Line 8: used by indicate to
: the operating system that
maybe "used by the operating system to indicate that" ?
File src/drivers/pcie/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/61627/comment/fb79264d_127f9095
PS1, Line 20: dev
Given you're going to check dev for null, it's safer to check this before dereferencing it on line 17 above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53986614dcbf4d10a6bb4010e131f5ff5a9d25cf
Gerrit-Change-Number: 61627
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 04 Feb 2022 22:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment