Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Martin Roth, Fred Reitberger.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66847 )
Change subject: mb/google/skyrim/port_descriptors: update DDI for MDN ......................................................................
Patch Set 6:
(6 comments)
File src/mainboard/google/skyrim/port_descriptors.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/6dc6b801_a9d152a5 PS6, Line 71: { /* DDI4 - Unused */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/4c17def7_fe2dcfd2 PS6, Line 71: { /* DDI4 - Unused */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/e6f2e525_66e0b3e7 PS6, Line 71: { /* DDI4 - Unused */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/1c30ddda_0ccf6423 PS6, Line 72: .connector_type = DDI_UNUSED_TYPE, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/55df07c7_e6bb3bae PS6, Line 72: .connector_type = DDI_UNUSED_TYPE, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/1ae8ca04_d7bc403c PS6, Line 72: .connector_type = DDI_UNUSED_TYPE, please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)