Change in coreboot[master]: soc/intel/tigerlake: Update header to avoid compilation issue
Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39630 )
Change subject: soc/intel/tigerlake: Update header to avoid compilation issue ......................................................................
soc/intel/tigerlake: Update header to avoid compilation issue
We were including stddefs.h and stdint.h but compilation fails when we use 'bool' type in file. Removing stddef.h and stdint.h and including 'types.h' which includes all data types
BUG=None BRANCH=None TEST=Check if compilation passes when bool is used
Change-Id: I4c9001f729f3103deba9d1fd631a8942c23276ee Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/soc/intel/tigerlake/include/soc/meminit_jsl.h 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/39630/1
diff --git a/src/soc/intel/tigerlake/include/soc/meminit_jsl.h b/src/soc/intel/tigerlake/include/soc/meminit_jsl.h index 588ad5c..66050b2 100644 --- a/src/soc/intel/tigerlake/include/soc/meminit_jsl.h +++ b/src/soc/intel/tigerlake/include/soc/meminit_jsl.h @@ -16,8 +16,7 @@ #ifndef _SOC_JASPERLAKE_MEMCFG_INIT_H_ #define _SOC_JASPERLAKE_MEMCFG_INIT_H_
-#include <stddef.h> -#include <stdint.h> +#include <types.h> #include <fsp/soc_binding.h>
/* Number of dq bits controlled per dqs */
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39630 )
Change subject: soc/intel/tigerlake: Update header to avoid compilation issue ......................................................................
Patch Set 1: Code-Review+1
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39630 )
Change subject: soc/intel/tigerlake: Update header to avoid compilation issue ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39630 )
Change subject: soc/intel/tigerlake: Update header to avoid compilation issue ......................................................................
Patch Set 1: Code-Review+2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39630 )
Change subject: soc/intel/tigerlake: Update header to avoid compilation issue ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39630 )
Change subject: soc/intel/tigerlake: Update header to avoid compilation issue ......................................................................
soc/intel/tigerlake: Update header to avoid compilation issue
We were including stddefs.h and stdint.h but compilation fails when we use 'bool' type in file. Removing stddef.h and stdint.h and including 'types.h' which includes all data types
BUG=None BRANCH=None TEST=Check if compilation passes when bool is used
Change-Id: I4c9001f729f3103deba9d1fd631a8942c23276ee Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39630 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Ronak Kanabar ronak.kanabar@intel.com Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/tigerlake/include/soc/meminit_jsl.h 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Aamir Bohra: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Ronak Kanabar: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/include/soc/meminit_jsl.h b/src/soc/intel/tigerlake/include/soc/meminit_jsl.h index 7f860ed..b828ae1 100644 --- a/src/soc/intel/tigerlake/include/soc/meminit_jsl.h +++ b/src/soc/intel/tigerlake/include/soc/meminit_jsl.h @@ -15,8 +15,7 @@ #ifndef _SOC_JASPERLAKE_MEMCFG_INIT_H_ #define _SOC_JASPERLAKE_MEMCFG_INIT_H_
-#include <stddef.h> -#include <stdint.h> +#include <types.h> #include <fsp/soc_binding.h>
/* Number of dq bits controlled per dqs */
-
Aamir Bohra (Code Review) -
Angel Pons (Code Review)
-
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)
-
Ronak Kanabar (Code Review)