Hello HAOUAS Elyes,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/38879
to review the following change.
Change subject: [TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................
[TESTME]mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic3fda4e598af8df9c9ddc97f7eb7fdcdaff6580b --- M src/mainboard/amd/parmer/Kconfig M src/mainboard/amd/parmer/Kconfig.name M src/mainboard/amd/parmer/Makefile.inc R src/mainboard/amd/parmer/bootblock.c 4 files changed, 6 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/38879/1
diff --git a/src/mainboard/amd/parmer/Kconfig b/src/mainboard/amd/parmer/Kconfig index ae024dd..820d43e 100644 --- a/src/mainboard/amd/parmer/Kconfig +++ b/src/mainboard/amd/parmer/Kconfig @@ -13,14 +13,10 @@ # GNU General Public License for more details. #
-config BOARD_AMD_PARMER - def_bool n - if BOARD_AMD_PARMER
config BOARD_SPECIFIC_OPTIONS def_bool y - #select ROMCC_BOOTBLOCK select CPU_AMD_AGESA_FAMILY15_TN select NORTHBRIDGE_AMD_AGESA_FAMILY15_TN select SOUTHBRIDGE_AMD_AGESA_HUDSON diff --git a/src/mainboard/amd/parmer/Kconfig.name b/src/mainboard/amd/parmer/Kconfig.name index 0771468..3aedc95 100644 --- a/src/mainboard/amd/parmer/Kconfig.name +++ b/src/mainboard/amd/parmer/Kconfig.name @@ -1,2 +1,2 @@ -#config BOARD_AMD_PARMER -# bool"Parmer" +config BOARD_AMD_PARMER + bool "Parmer" diff --git a/src/mainboard/amd/parmer/Makefile.inc b/src/mainboard/amd/parmer/Makefile.inc index f8895fa..4dde2cf 100644 --- a/src/mainboard/amd/parmer/Makefile.inc +++ b/src/mainboard/amd/parmer/Makefile.inc @@ -13,6 +13,8 @@ # GNU General Public License for more details. #
+bootblock-y += bootblock.c + romstage-y += buildOpts.c romstage-y += BiosCallOuts.c romstage-y += OemCustomize.c diff --git a/src/mainboard/amd/parmer/romstage.c b/src/mainboard/amd/parmer/bootblock.c similarity index 68% rename from src/mainboard/amd/parmer/romstage.c rename to src/mainboard/amd/parmer/bootblock.c index 6366c4e..fea4d7b 100644 --- a/src/mainboard/amd/parmer/romstage.c +++ b/src/mainboard/amd/parmer/bootblock.c @@ -13,14 +13,9 @@ * GNU General Public License for more details. */
+#include <bootblock_common.h> #include <device/pci_ops.h> -#include <northbridge/amd/agesa/state_machine.h> -#include <southbridge/amd/agesa/hudson/hudson.h>
-void board_BeforeAgesa(struct sysinfo *cb) +void bootblock_mainboard_early_init(void) { - pci_devfn_t dev = PCI_DEV(0, 0x14, 3); - - /* For serial port option, plug-in card on LPC. */ - pci_write_config32(dev, 0x44, 0xff03ffd5); }
Hello HAOUAS Elyes, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38879
to look at the new patch set (#4).
Change subject: mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic3fda4e598af8df9c9ddc97f7eb7fdcdaff6580b --- M src/mainboard/amd/parmer/Kconfig M src/mainboard/amd/parmer/Kconfig.name M src/mainboard/amd/parmer/Makefile.inc R src/mainboard/amd/parmer/bootblock.c 4 files changed, 6 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/38879/4
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38879 )
Change subject: mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 4: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38879 )
Change subject: mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38879 )
Change subject: mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic3fda4e598af8df9c9ddc97f7eb7fdcdaff6580b Reviewed-on: https://review.coreboot.org/c/coreboot/+/38879 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/parmer/Kconfig M src/mainboard/amd/parmer/Kconfig.name M src/mainboard/amd/parmer/Makefile.inc R src/mainboard/amd/parmer/bootblock.c 4 files changed, 6 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/amd/parmer/Kconfig b/src/mainboard/amd/parmer/Kconfig index ae024dd..820d43e 100644 --- a/src/mainboard/amd/parmer/Kconfig +++ b/src/mainboard/amd/parmer/Kconfig @@ -13,14 +13,10 @@ # GNU General Public License for more details. #
-config BOARD_AMD_PARMER - def_bool n - if BOARD_AMD_PARMER
config BOARD_SPECIFIC_OPTIONS def_bool y - #select ROMCC_BOOTBLOCK select CPU_AMD_AGESA_FAMILY15_TN select NORTHBRIDGE_AMD_AGESA_FAMILY15_TN select SOUTHBRIDGE_AMD_AGESA_HUDSON diff --git a/src/mainboard/amd/parmer/Kconfig.name b/src/mainboard/amd/parmer/Kconfig.name index 0771468..3aedc95 100644 --- a/src/mainboard/amd/parmer/Kconfig.name +++ b/src/mainboard/amd/parmer/Kconfig.name @@ -1,2 +1,2 @@ -#config BOARD_AMD_PARMER -# bool"Parmer" +config BOARD_AMD_PARMER + bool "Parmer" diff --git a/src/mainboard/amd/parmer/Makefile.inc b/src/mainboard/amd/parmer/Makefile.inc index f8895fa..4dde2cf 100644 --- a/src/mainboard/amd/parmer/Makefile.inc +++ b/src/mainboard/amd/parmer/Makefile.inc @@ -13,6 +13,8 @@ # GNU General Public License for more details. #
+bootblock-y += bootblock.c + romstage-y += buildOpts.c romstage-y += BiosCallOuts.c romstage-y += OemCustomize.c diff --git a/src/mainboard/amd/parmer/romstage.c b/src/mainboard/amd/parmer/bootblock.c similarity index 68% rename from src/mainboard/amd/parmer/romstage.c rename to src/mainboard/amd/parmer/bootblock.c index 6366c4e..fea4d7b 100644 --- a/src/mainboard/amd/parmer/romstage.c +++ b/src/mainboard/amd/parmer/bootblock.c @@ -13,14 +13,9 @@ * GNU General Public License for more details. */
+#include <bootblock_common.h> #include <device/pci_ops.h> -#include <northbridge/amd/agesa/state_machine.h> -#include <southbridge/amd/agesa/hudson/hudson.h>
-void board_BeforeAgesa(struct sysinfo *cb) +void bootblock_mainboard_early_init(void) { - pci_devfn_t dev = PCI_DEV(0, 0x14, 3); - - /* For serial port option, plug-in card on LPC. */ - pci_write_config32(dev, 0x44, 0xff03ffd5); }
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38879 )
Change subject: mb/amd/parmer: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 5:
I'll get a parmer board set up so we can boot test against it.
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)
-
Mike Banon (Code Review)
-
Patrick Georgi (Code Review)