Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/19576 )
Change subject: soc/intel/apollolake: Add marco to define IOSTERM for GPIO config
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19576/1/src/soc/intel/apollolake/include/soc...
File src/soc/intel/apollolake/include/soc/gpio.h:
Line 76: PAD_IOSSTATE(iosstate) | PAD_IOSTERM(iosterm)
Can you please just call this one from PAD_CFG_NF_IOSSTATE and PAD_CFG_NF_I
Is new patch set will be expected to call the macro?
--
To view, visit
https://review.coreboot.org/19576
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I178f6d3055d4620cb3c895245c40f324383873ad
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@intel.com
Gerrit-Reviewer: Freddy Paul
freddy.paul@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes