Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35944 )
Change subject: mb/google/hatch: Add new touchscreen option for Kohaku ......................................................................
mb/google/hatch: Add new touchscreen option for Kohaku
The next board rev will have a new option for an Elan touchscreen. Add support for this in the devicetree, as well as use the 'probed' property on both touchscreen options.
BUG=b:141957731 BRANCH=none TEST=compiles (next board rev not available yet)
Change-Id: I135e693304cbb8dffc0caf4c07846033d6802208 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/35944/1
diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 37914fa..ecf4682 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -179,8 +179,24 @@ register "enable_delay_ms" = "1" # 90 ns register "has_power_resource" = "1" register "disable_gpio_export_in_crs" = "1" + register "probed" = "1" device i2c 4b on end end + + chip drivers/i2c/generic + register "hid" = ""ELAN0001"" + register "desc" = ""ELAN Touchscreen"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "probed" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C12)" + register "enable_delay_ms" = "10" + register "enable_off_delay_ms" = "100" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "reset_delay_ms" = "20" + register "reset_off_delay_ms" = "2" + register "has_power_resource" = "1" + device i2c 10 on end + end end # I2C #1
device pci 15.2 on
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35944 )
Change subject: mb/google/hatch: Add new touchscreen option for Kohaku ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35944/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35944/1/src/mainboard/google/hatch/... PS1, Line 189: ACPI_IRQ_EDGE_LOW Does this have a different trigger than atmel?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35944 )
Change subject: mb/google/hatch: Add new touchscreen option for Kohaku ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35944/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35944/1/src/mainboard/google/hatch/... PS1, Line 189: ACPI_IRQ_EDGE_LOW
Does this have a different trigger than atmel?
Yes. Some Octopus devices used this same touchscreen, and they are using edge-triggered.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35944 )
Change subject: mb/google/hatch: Add new touchscreen option for Kohaku ......................................................................
Patch Set 1: Code-Review+1
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35944 )
Change subject: mb/google/hatch: Add new touchscreen option for Kohaku ......................................................................
Patch Set 1: Code-Review+2
Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35944 )
Change subject: mb/google/hatch: Add new touchscreen option for Kohaku ......................................................................
mb/google/hatch: Add new touchscreen option for Kohaku
The next board rev will have a new option for an Elan touchscreen. Add support for this in the devicetree, as well as use the 'probed' property on both touchscreen options.
BUG=b:141957731 BRANCH=none TEST=compiles (next board rev not available yet)
Change-Id: I135e693304cbb8dffc0caf4c07846033d6802208 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/35944 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 16 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index bd60973..55ac071 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -179,8 +179,24 @@ register "enable_delay_ms" = "1" # 90 ns register "has_power_resource" = "1" register "disable_gpio_export_in_crs" = "1" + register "probed" = "1" device i2c 4b on end end + + chip drivers/i2c/generic + register "hid" = ""ELAN0001"" + register "desc" = ""ELAN Touchscreen"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "probed" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C12)" + register "enable_delay_ms" = "10" + register "enable_off_delay_ms" = "100" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "reset_delay_ms" = "20" + register "reset_off_delay_ms" = "2" + register "has_power_resource" = "1" + device i2c 10 on end + end end # I2C #1
device pci 15.2 on
-
Paul Fagerburg (Code Review) -
Shelley Chen (Code Review)
-
Tim Wawrzynczak (Code Review)